openstack/deb-python-sqlalchemy-utils
Code Issues Proposed changes

FetchingCoordinator -> fetcher_factory (better name)

Browse Source
This commit is contained in:
Konsta Vesterinen
2013-08-22 21:48:07 +03:00
parent 7a98f47e4c
commit 52c7acd763
1 changed files with 18 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
sqlalchemy_utils/functions/batch_fetch.py
View File

@@ -143,30 +143,28 @@ def batch_fetch(entities, *attr_paths):
"""
if entities:
fetcher = FetchingCoordinator()
for attr_path in attr_paths:
fetcher(entities, attr_path)
for path in attr_paths:
fetcher = fetcher_factory(entities, path)
fetcher.fetch()
fetcher.populate()
class FetchingCoordinator(object):
def __call__(self, entities, path):
populate_backrefs = False
if isinstance(path, with_backrefs):
path = path.path
populate_backrefs = True
def fetcher_factory(entities, path):
populate_backrefs = False
if isinstance(path, with_backrefs):
path = path.path
populate_backrefs = True
if isinstance(path, CompositePath):
fetchers = []
for path in path.paths:
fetchers.append(
Path.parse(entities, path, populate_backrefs).fetcher
)
if isinstance(path, CompositePath):
fetchers = []
for path in path.paths:
fetchers.append(
Path.parse(entities, path, populate_backrefs).fetcher
)
fetcher = CompositeFetcher(*fetchers)
else:
fetcher = Path.parse(entities, path, populate_backrefs).fetcher
fetcher.fetch()
fetcher.populate()
return CompositeFetcher(*fetchers)
else:
return Path.parse(entities, path, populate_backrefs).fetcher
class CompositeFetcher(object):