openstack/deb-python-taskflow
Code Issues Proposed changes

Use the full 'get_execute_failures' vs the shortname

Browse Source 
The usage of the full name is easier to read and easier
to understand in the surronding code so prefer to use
it.

Change-Id: I1c43704ae7dfdba90217ce9a1c60cef8e2ce8632
This commit is contained in:
Joshua Harlow
2016-05-28 21:59:44 -07:00
parent 459b0a2c6a
commit 0766397b54
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
taskflow/engines/action_engine/engine.py
View File

@@ -332,12 +332,12 @@ class ActionEngine(base.Engine):
if new_state not in self.IGNORABLE_STATES:
self._change_state(new_state)
if new_state not in self.NO_RERAISING_STATES:
failures = self.storage.get_failures()
more_failures = self.storage.get_revert_failures()
fails = itertools.chain(
six.itervalues(failures),
six.itervalues(more_failures))
failure.Failure.reraise_if_any(fails)
e_failures = self.storage.get_execute_failures()
r_failures = self.storage.get_revert_failures()
er_failures = itertools.chain(
six.itervalues(e_failures),
six.itervalues(r_failures))
failure.Failure.reraise_if_any(er_failures)
finally:
if w is not None:
w.stop()