openstack/deb-python-taskflow
Code Issues Proposed changes

Add edge labels for engine states

Browse Source 
The engine state diagram benefits slightly from having
the event labels that cause transitions to other states
so we might as well include it in the generated diagram.

Change-Id: I733eba1d2dc6386c7b7ce8930fbfd41e29cdb602
This commit is contained in:
Joshua Harlow
2014-12-21 16:23:10 -08:00
parent ae77c412e7
commit 1d84fdd094
2 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
doc/source/img/engine_states.svg
View File

File diff suppressed because one or more lines are too long
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 22 KiB

After

Width:  |  Height:  |  Size: 24 KiB

17
tools/state_graph.py
View File

@@ -128,7 +128,7 @@ def main():
'fontsize': '11',
}
nodes = {}
for (start_state, _on_event, end_state) in source:
for (start_state, on_event, end_state) in source:
if start_state not in nodes:
start_node_attrs = node_attrs.copy()
text_color = map_color(internal_states, start_state)
@@ -143,7 +143,20 @@ def main():
end_node_attrs['fontcolor'] = text_color
nodes[end_state] = pydot.Node(end_state, **end_node_attrs)
g.add_node(nodes[end_state])
g.add_edge(pydot.Edge(nodes[start_state], nodes[end_state]))
if options.engines:
edge_attrs = {
'label': "on %s" % on_event
}
if 'reverted' in on_event:
edge_attrs['fontcolor'] = 'darkorange'
if 'fail' in on_event:
edge_attrs['fontcolor'] = 'red'
if 'success' in on_event:
edge_attrs['fontcolor'] = 'green'
else:
edge_attrs = {}
g.add_edge(pydot.Edge(nodes[start_state], nodes[end_state],
**edge_attrs))
start = pydot.Node("__start__", shape="point", width="0.1",
xlabel='start', fontcolor='green', **node_attrs)