openstack/deb-python-taskflow
Code Issues Proposed changes

Put underscore in-front of alchemist helper

Browse Source 
Since this is a internal helper object we should
put a underscore infront of its class name to make
sure this is obvious (the docstring says the same
thing but this will help).

Change-Id: I3aeb6a178c8ceda0c36d5f5bb57bb765260cbd3c
This commit is contained in:
Joshua Harlow
2015-03-11 15:25:41 -07:00
parent fc1d0a9f75
commit 844c2c69ab
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
taskflow/persistence/backends/impl_sqlalchemy.py
View File

@@ -180,7 +180,7 @@ def _ping_listener(dbapi_conn, connection_rec, connection_proxy):
raise
class Alchemist(object):
class _Alchemist(object):
"""Internal <-> external row <-> objects + other helper functions.
NOTE(harlowja): for internal usage only.
@@ -343,7 +343,7 @@ class Connection(base.Connection):
self._engine = backend.engine
self._metadata = sa.MetaData()
self._tables = tables.fetch(self._metadata)
self._converter = Alchemist(self._tables)
self._converter = _Alchemist(self._tables)
@property
def backend(self):