openstack/deb-python-taskflow
Code Issues Proposed changes

Name the graph property the same as in engine

Browse Source 
In order to keep consistency between the engine
properties and the analyzer/decider properties
we should try to keep the naming the same (in
this case they both return the execution_graph).

Change-Id: I981d13c68ab597a91dadea2925183674d027ce0b
This commit is contained in:
Joshua Harlow
2013-12-26 18:10:11 -08:00
parent 2538c4810a
commit af8561963a
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
taskflow/engines/action_engine/engine.py
View File

@@ -98,7 +98,7 @@ class ActionEngine(base.EngineBase):
@property
def execution_graph(self):
self.compile()
return self._analyzer.graph
return self._analyzer.execution_graph
@lock_utils.locked
def run(self):

7
taskflow/engines/action_engine/graph_analyzer.py
View File

@@ -22,14 +22,17 @@ from taskflow import states as st
class GraphAnalyzer(object):
"""Analyzes graph to get next nodes for execution or reversion"""
"""Analyzes a execution graph to get the next nodes for execution or
reversion by utilizing the graphs nodes and edge relations and comparing
the node state against the states stored in storage.
"""
def __init__(self, graph, storage):
self._graph = graph
self._storage = storage
@property
def graph(self):
def execution_graph(self):
return self._graph
def browse_nodes_for_execute(self, node=None):