openstack/deb-python-taskflow
Code Issues Proposed changes

Raise NotImplementedError instead of NotImplemented

Browse Source 
Change-Id: I6ba5e21c801f724f216298d383a523f7dd865d6a
This commit is contained in:
Christian Berendt
2014-07-04 13:07:37 +02:00
parent 3db326a68c
commit c5242a696c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
taskflow/persistence/logbook.py
View File

@@ -411,7 +411,7 @@ class TaskDetail(AtomDetail):
def merge(self, other, deep_copy=False):
if not isinstance(other, TaskDetail):
raise NotImplemented("Can only merge with other task details")
raise NotImplementedError("Can only merge with other task details")
if other is self:
return self
super(TaskDetail, self).merge(other, deep_copy=deep_copy)
@@ -496,7 +496,8 @@ class RetryDetail(AtomDetail):
def merge(self, other, deep_copy=False):
if not isinstance(other, RetryDetail):
raise NotImplemented("Can only merge with other retry details")
raise NotImplementedError("Can only merge with other retry "
"details")
if other is self:
return self
super(RetryDetail, self).merge(other, deep_copy=deep_copy)