openstack/deb-python-taskflow
Code Issues Proposed changes

Add note about thread safety of fake filesystem

Browse Source 
Change-Id: Ic9851455b559a94bb011c27ba55ad050e6bd6d55
This commit is contained in:
Joshua Harlow
2015-04-08 14:04:38 -07:00
parent 830e4e03cb
commit c64ca27fb3
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
taskflow/persistence/backends/impl_memory.py
View File

@@ -37,6 +37,15 @@ class FakeFilesystem(object):
which are not relevant in an implementation of a in-memory fake
filesystem).
**Not** thread-safe when a single filesystem is mutated at the same
time by multiple threads. For example having multiple threads call into
:meth:`~taskflow.persistence.backends.impl_memory.FakeFilesystem.clear`
at the same time could potentially end badly. It is thread-safe when only
:meth:`~taskflow.persistence.backends.impl_memory.FakeFilesystem.get`
or other read-only actions (like calling into
:meth:`~taskflow.persistence.backends.impl_memory.FakeFilesystem.ls`)
are occuring at the same time.
Example usage:
>>> from taskflow.persistence.backends import impl_memory
@@ -142,6 +151,7 @@ class FakeFilesystem(object):
return paths
def clear(self):
"""Remove all nodes (except the root) from this filesystem."""
for node in list(self._root.reverse_iter()):
node.disassociate()