openstack/deb-python-taskflow
Code Issues Proposed changes

Add the ability to skip resolving from activating

Browse Source 
It can be useful for debugging a failure to be able
to stop when a failure is detected so that the failure
can be examined in more detail.

This adds the ability to have a 'never_resolve' engine
option which will skip such resolution attempts for
these types of scenarios.

Change-Id: If2386cba970e14c7168a6ff2d4fd4786bcd8e989
This commit is contained in:
Joshua Harlow
2016-04-04 17:08:23 -07:00
parent 29ba91e93f
commit ddf58ff79a
2 changed files with 25 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
taskflow/engines/action_engine/completer.py
View File

@@ -111,6 +111,8 @@ class Completer(object):
self._undefined_resolver = RevertAll(self._runtime)
self._defer_reverts = strutils.bool_from_string(
self._runtime.options.get('defer_reverts', False))
self._resolve = not strutils.bool_from_string(
self._runtime.options.get('never_resolve', False))
def resume(self):
"""Resumes atoms in the contained graph.
@@ -126,14 +128,17 @@ class Completer(object):
atoms = list(self._analyzer.iterate_nodes(co.ATOMS))
atom_states = self._storage.get_atoms_states(atom.name
for atom in atoms)
for atom in atoms:
atom_state, _atom_intention = atom_states[atom.name]
if atom_state == st.FAILURE:
self._process_atom_failure(atom, self._storage.get(atom.name))
for retry in self._analyzer.iterate_retries(st.RETRYING):
for atom, state, intention in self._runtime.retry_subflow(retry):
if state:
atom_states[atom.name] = (state, intention)
if self._resolve:
for atom in atoms:
atom_state, _atom_intention = atom_states[atom.name]
if atom_state == st.FAILURE:
self._process_atom_failure(
atom, self._storage.get(atom.name))
for retry in self._analyzer.iterate_retries(st.RETRYING):
retry_affected_atoms_it = self._runtime.retry_subflow(retry)
for atom, state, intention in retry_affected_atoms_it:
if state:
atom_states[atom.name] = (state, intention)
unfinished_atoms = set()
for atom in atoms:
atom_state, _atom_intention = atom_states[atom.name]
@@ -149,12 +154,13 @@ class Completer(object):
Returns whether the result should be saved into an accumulator of
failures or whether this should not be done.
"""
if outcome == ex.EXECUTED:
if outcome == ex.EXECUTED and self._resolve:
self._process_atom_failure(node, failure)
# We resolved something, carry on...
return False
else:
# Reverting failed, always retain the failure...
# Reverting failed (or resolving was turned off), always
# retain the failure...
return True
def complete(self, node, outcome, result):

9
taskflow/engines/action_engine/engine.py
View File

@@ -116,6 +116,15 @@ class ActionEngine(base.Engine):
| | has a separate retry | | |
| | behavior). | | |
+----------------------+-----------------------+------+------------+
| ``never_resolve`` | When true, instead | bool | ``False`` |
| | of reverting | | |
| | and trying to resolve | | |
| | a atom failure the | | |
| | engine will skip | | |
| | reverting and abort | | |
| | instead of reverting | | |
| | and/or retrying. | | |
+----------------------+-----------------------+------+------------+
| ``inject_transient`` | When true, values | bool | ``True`` |
| | that are local to | | |
| | each atoms scope | | |