openstack/deb-python-taskflow
Code Issues Proposed changes

Merge "Cache immutable visible scopes in the runtime component"

Browse Source
This commit is contained in:
Jenkins
2014-12-03 08:48:48 +00:00
committed by Gerrit Code Review
parent 6f946640e4 a69213821c
commit e707be4f34
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
taskflow/engines/action_engine/runtime.py
View File

@@ -40,6 +40,7 @@ class Runtime(object):
self._task_executor = task_executor
self._storage = storage
self._compilation = compilation
self._scopes = {}
@property
def compilation(self):
@@ -68,17 +69,23 @@ class Runtime(object):
@misc.cachedproperty
def retry_action(self):
return ra.RetryAction(self._storage, self._atom_notifier,
lambda atom: sc.ScopeWalker(self.compilation,
atom,
names_only=True))
self._fetch_scopes_for)
@misc.cachedproperty
def task_action(self):
return ta.TaskAction(self._storage, self._task_executor,
self._atom_notifier,
lambda atom: sc.ScopeWalker(self.compilation,
atom,
names_only=True))
self._atom_notifier, self._fetch_scopes_for)
def _fetch_scopes_for(self, atom):
"""Fetches a tuple of the visible scopes for the given atom."""
try:
return self._scopes[atom]
except KeyError:
walker = sc.ScopeWalker(self.compilation, atom,
names_only=True)
visible_to = tuple(walker)
self._scopes[atom] = visible_to
return visible_to
# Various helper methods used by the runtime components; not for public
# consumption...