openstack/deb-python-taskflow
Code Issues Proposed changes

Reduce visibility of task_action

Browse Source 
Task action is an internal to the action
engine init and runtime and shouldn't
become part of the public api of the action
engine type.

Change-Id: I68a10a83718f70cc037e7aaa9259c7bfdc9b93a4
This commit is contained in:
Joshua Harlow
2014-01-04 07:26:56 -08:00
parent 5352debceb
commit f1058af707
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
taskflow/engines/action_engine/engine.py
View File

@@ -62,9 +62,9 @@ class ActionEngine(base.EngineBase):
self.notifier = misc.TransitionNotifier()
self.task_notifier = misc.TransitionNotifier()
self._task_executor = self._task_executor_cls()
self.task_action = self._task_action_cls(self.storage,
self._task_executor,
self.task_notifier)
self._task_action = self._task_action_cls(self.storage,
self._task_executor,
self.task_notifier)
def _revert(self, current_failure=None):
self._change_state(states.REVERTING)
@@ -176,7 +176,7 @@ class ActionEngine(base.EngineBase):
self.storage)
self._root = self._graph_action_cls(self._analyzer,
self.storage,
self.task_action)
self._task_action)
for task in task_graph.nodes_iter():
task_version = misc.get_version_string(task)
self.storage.ensure_task(task.name, task_version, task.save_as)