a14adc3c62
Apparently the execution of four-letter commands to zookeeper is known to be flakey (and you may receive partial results) so to avoid this use the retrying library during fetching/parsing of the server version and try up to 3 times to get a valid version from the zookeeper server. When the following merges (and is released) we can likely remove this equivalent/similar code: https://github.com/python-zk/kazoo/pull/280 Change-Id: I9191c463c7969df101541463a76fe20ff5ed06af
57 lines
2.1 KiB
Python
57 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (C) 2015 Yahoo! Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from kazoo import client
|
|
from kazoo import exceptions as k_exc
|
|
from six.moves import range as compat_range
|
|
|
|
from taskflow import test
|
|
from taskflow.test import mock
|
|
from taskflow.utils import kazoo_utils as ku
|
|
|
|
_FAKE_ZK_VER = (3, 4, 0)
|
|
|
|
|
|
def _iter_succeed_after(attempts):
|
|
for i in compat_range(0, attempts):
|
|
if i % 2 == 0:
|
|
yield ValueError("Broken")
|
|
else:
|
|
yield AttributeError("Broken")
|
|
yield _FAKE_ZK_VER
|
|
|
|
|
|
class KazooUtilTest(test.TestCase):
|
|
def test_flakey_version_fetch_fail(self):
|
|
m = mock.create_autospec(client.KazooClient, instance=True)
|
|
m.server_version.side_effect = _iter_succeed_after(11)
|
|
self.assertRaises(k_exc.KazooException,
|
|
ku.fetch_server_version, m, 10)
|
|
self.assertEqual(10, m.server_version.call_count)
|
|
|
|
def test_flakey_version_fetch_fail_truncated(self):
|
|
m = mock.create_autospec(client.KazooClient, instance=True)
|
|
m.server_version.side_effect = [None, [], "", [1]]
|
|
self.assertRaises(k_exc.KazooException,
|
|
ku.fetch_server_version, m, 4)
|
|
self.assertEqual(4, m.server_version.call_count)
|
|
|
|
def test_flakey_version_fetch_pass(self):
|
|
m = mock.create_autospec(client.KazooClient, instance=True)
|
|
m.server_version.side_effect = _iter_succeed_after(4)
|
|
self.assertEqual((3, 4, 0), ku.fetch_server_version(m, 5))
|
|
self.assertEqual(5, m.server_version.call_count)
|