- use bytearray(n) instead of str().zfill(n)
- test data are more strictly.
Signed-off-by: HIYAMA Manabu <hiyama.manabu@po.ntts.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This was preventing from creating a package on Windows machines where
there is no /etc/ folder.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
- zfill() is a func of the string to be putting in a '0'.
bytearray().zfill(n) -> bytearray(n)
- unify notation of zero with other code.
'\0' -> '\x00'
Signed-off-by: HIYAMA Manabu <hiyama.manabu@po.ntts.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
also make checksum handling consistent with the other code.
Signed-off-by: HIYAMA Manabu <hiyama.manabu@po.ntts.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
- some tests need attached port to switch.
Signed-off-by: HIYAMA Manabu <hiyama.manabu@po.ntts.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Rearrange the top page in the following way:
- Getting Started
- Cloud Integration (OpenStack only for now)
- Developing Your App
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
The 'getting_started' content overlaps with README. It also includes
more advanced information than 'getting_started'. This is preparation
for making README 'getting_started'.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
The following docs are about OpenStack:
using_with_openstack.rst
step_by_step.rst
how_l2_segregation_work.rst
So let's create 'OpenStack' section in the index and put three under
the section.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This patch only removes unnecessary methods that didn't accord with
the library changed at ae0253a36c.
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
- we don't need register_cls() any more.
- register_instance() isn't called with dispatchers argument.
- set_ev_cls is always called with dispatchers argument.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
No reason that we use register_cls() for ofp handlers. We can do with
register_instance() with the others do.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
I don't see any reason why we need to handle those two OFP messages as
differently as the rest.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
We don't send OFPC_DELETE OFPFlowMod or OFPBarrier during
CONFIG_DISPATCHER so we don't need OFPFlowRemoved and OFPBarrierReply.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
We don't send OFPEchoRequest so there is no point to have OFPEchoReply
handler.
I think that sending OFPEchoRequest is useful for some cases
(e.g. finding problems on the switch quickly). But that should be
another helper dispatcher since not all applications need such.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
All protocols need to check if the data length is long enough so let's
set the minimum length in the same way.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
- we need to serialize in reverse order since some need to know
payload.
- TCP and UDP need the previous protocol info (IP) to calculate the
checksum.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Fix the following:
ryu/ofproto/ofproto_v1_2_parser.py", line 1701, in parser
type_, length = struct.unpack_from('!HH', buf, offset)
TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>