3cb08bc52b
* add hacking check: no_mutable_default_args()
* remove the mutable default arguments "[]" or "{}" when the function
is defined.
ref: http://docs.python-guide.org/en/latest/writing/gotchas/
Closes-Bug: #1530282
Change-Id: Ice6f7654211b73d7f8bc3ca0e4dfae3dca354397
54 lines
1.4 KiB
ReStructuredText
54 lines
1.4 KiB
ReStructuredText
Sahara Style Commandments
|
|
==========================
|
|
|
|
- Step 1: Read the OpenStack Style Commandments
|
|
http://docs.openstack.org/developer/hacking/
|
|
- Step 2: Read on
|
|
|
|
Sahara Specific Commandments
|
|
-----------------------------
|
|
|
|
Commit Messages
|
|
---------------
|
|
Using a common format for commit messages will help keep our git history
|
|
readable. Follow these guidelines:
|
|
|
|
- [S365] First, provide a brief summary of 50 characters or less. Summaries
|
|
of greater then 72 characters will be rejected by the gate.
|
|
|
|
- [S364] The first line of the commit message should provide an accurate
|
|
description of the change, not just a reference to a bug or blueprint.
|
|
|
|
Imports
|
|
-------
|
|
- [S366, S367] Organize your imports according to the ``Import order``
|
|
|
|
Dictionaries/Lists
|
|
------------------
|
|
|
|
- [S360] Ensure default arguments are not mutable.
|
|
- [S368] Must use a dict comprehension instead of a dict constructor with a
|
|
sequence of key-value pairs. For more information, please refer to
|
|
http://legacy.python.org/dev/peps/pep-0274/
|
|
=======
|
|
Logs
|
|
----
|
|
|
|
- [S369] Check LOG.info translations
|
|
|
|
- [S370] Check LOG.error translations
|
|
|
|
- [S371] Check LOG.warning translations
|
|
|
|
- [S372] Check LOG.critical translation
|
|
|
|
- [S373] LOG.debug never used for translations
|
|
|
|
- [S374] You used a deprecated log level
|
|
|
|
Importing json
|
|
--------------
|
|
|
|
- [S375] It's more preferable to use ``jsonutils`` from ``oslo_serialization``
|
|
instead of ``json`` for operating with ``json`` objects.
|