openstack/designate-tempest-plugin
Code Issues Proposed changes

Merge "expected_success should be a classmethod"

Browse Source
This commit is contained in:
Jenkins 2016-05-13 14:32:12 +00:00 committed by Gerrit Code Review
commit 42f2ce09a2
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
designate_tempest_plugin/services/dns/json/base.py
View File

@ -60,7 +60,8 @@ class DnsClientBase(rest_client.RestClient):
else:
raise lib_exc.InvalidContentType()
def expected_success(self, expected_code, read_code):
@classmethod
def expected_success(cls, expected_code, read_code):
# the base class method does not check correctly if read_code is not
# an int. warn about this and cast to int to avoid silent errors.
if not isinstance(read_code, int):
@ -69,7 +70,7 @@ class DnsClientBase(rest_client.RestClient):
{'expected_code': expected_code,
'read_code': read_code})
LOG.warn(message)
return super(DnsClientBase, self).expected_success(
return super(DnsClientBase, cls).expected_success(
expected_code=expected_code, read_code=int(read_code),
)