openstack/designate-tempest-plugin
Code Issues Proposed changes

Fix test_list_enabled_api_versions test case

Browse Source 
The test_list_enabled_api_versions was not properly checking the enabled API versions and would always fail on new API version additions.

This patch corrects the list comprehension and updates the test to look for at least one of the base API versions in the returned results. This way the test will not artificially fail as we add new API versions.

Change-Id: Ibcee798b15aaccf8fddd28f80df7112cda3a9ed5
This commit is contained in:
Michael Johnson 2023-01-29 00:04:47 +00:00
parent c9429994a4
commit adf6319c1c
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
designate_tempest_plugin/tests/api/v2/test_enabled_api_version.py
View File

@ -79,12 +79,13 @@ class DesignateApiVersion(base.BaseDnsV2Test, service_base.DnsClientV2Base):
LOG.info('Received enabled API versions for {} '
'user are:{}'.format(user, versions))
for item in versions:
enabled_ids = [
item['id'] for key in item.keys() if key == 'id']
enabled_ids = {item['id'] for item in versions}
LOG.info('Enabled versions IDs are:{}'.format(enabled_ids))
possible_options = [['v1'], ['v2'], ['v1', 'v2'], ['v2.0']]
self.assertIn(
enabled_ids, possible_options,
'Failed, received version: {} is not in possible options'
' list:{}'.format(enabled_ids, possible_options))
# Expect at least one of these to be present in the API
base_versions = {'v1', 'v2', 'v2.0'}
self.assertFalse(
enabled_ids.isdisjoint(base_versions),
'Failed, at least one base API version: {} was not found in '
'the API version list: {}'.format(base_versions, enabled_ids))