1104 lines
34 KiB
Plaintext
1104 lines
34 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f39ecd48_2cf74b3d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 5572
|
|
},
|
|
"writtenOn": "2022-11-01T22:57:17Z",
|
|
"side": 1,
|
|
"message": "LGTM - I even comment out the skips to make sure it still fails because of https://bugs.launchpad.net/designate/+bug/1992445\n\nall-plugin run-test: commands[3] | tempest run --regex designate_tempest_plugin.tests.scenario.v2.test_quotas\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_api_export_size_boundary ... SKIPPED: Skipped until bug: https://launchpad.net/bugs/1960495 is resolved.\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_api_export_size_quota ... SKIPPED: Skipped until bug: https://launchpad.net/bugs/1960495 is resolved.\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_recordset_records_boundary [1.829618s] ... ok\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_zone_quota_boundary [1.083670s] ... ok\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_zone_records_boundary [1.593833s] ... ok\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_zone_recordsets_boundary ... SKIPPED: Skipped until bug: https://launchpad.net/bugs/1992445 is resolved.\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_recordset_records_quota [13.694860s] ... ok\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_zone_records_quota [36.758744s] ... ok\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_zone_recordsets_quota [21.432003s] ... ok\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_zones_quota [20.539675s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 10 tests in 93.7436 sec.\n - Passed: 7\n - Skipped: 3\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 96.9347 sec.\n\n",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f79ba324_5dc2b686",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2022-12-29T08:23:20Z",
|
|
"side": 1,
|
|
"message": "recheck",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "08a2e67f_7fab1a73",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "I have added a few comments. I will rebase this as well to pull in the zones_client changes that merged today. Some will likely still need to be fixed here.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d4107768_d732e521",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 66,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This is going to need a rebase, this client was removed in favor of having one client created in the base class.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5c2e541a_6c8ef288",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 66,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T23:09:20Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d4107768_d732e521",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d5c5d7f9_56bf7f3c",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 357,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This will need to be updated to zones_client, a rebase might catch this.",
|
|
"range": {
|
|
"startLine": 357,
|
|
"startChar": 33,
|
|
"endLine": 357,
|
|
"endChar": 44
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7867c4e1_cf7581b3",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 357,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T23:09:20Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d5c5d7f9_56bf7f3c",
|
|
"range": {
|
|
"startLine": 357,
|
|
"startChar": 33,
|
|
"endLine": 357,
|
|
"endChar": 44
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "60887815_76227aa9",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 401,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "You do not want to sudo here as that project will not have enough permission to set a quota.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fe4220b3_7eea8ee4",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 401,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "I gave the client a \"bad\" name that misleads.\nSetting of quota for some project is done using the admin client, I\u0027ll replace \"quota_client\" to \"adm_quota_client\".",
|
|
"parentUuid": "60887815_76227aa9",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "77e9323a_7692ec60",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 401,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "fe4220b3_7eea8ee4",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "00a5e601_22a7af0a",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 406,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This will need to be updated to zones_client",
|
|
"range": {
|
|
"startLine": 406,
|
|
"startChar": 20,
|
|
"endLine": 406,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6c77634b_d6f380a1",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 406,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T23:09:20Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "00a5e601_22a7af0a",
|
|
"range": {
|
|
"startLine": 406,
|
|
"startChar": 20,
|
|
"endLine": 406,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2dc8c4af_f05e9968",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 410,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "I get that this is the 3rd because of the SOA/NS, but I think we want to fix this to be the \"1st\" for quota. Or at least leave a comment/todo\nCounting the SOA and NS can be odd give that a cloud could be running this test that has three NS records due to the pool configuration.\nPlus it makes this test confusing given you set a quota of one above on line 397",
|
|
"range": {
|
|
"startLine": 410,
|
|
"startChar": 19,
|
|
"endLine": 410,
|
|
"endChar": 23
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "20ebe565_134ce3fc",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 410,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Agree, in fact we do have a bug opened for this: \nhttps://bugs.launchpad.net/designate/+bug/1992445\nI\u0027ll add a comment saying that the test will need to be\nmodified according proposed fix.",
|
|
"parentUuid": "2dc8c4af_f05e9968",
|
|
"range": {
|
|
"startLine": 410,
|
|
"startChar": 19,
|
|
"endLine": 410,
|
|
"endChar": 23
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8216d090_437e06f5",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 410,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "20ebe565_134ce3fc",
|
|
"range": {
|
|
"startLine": 410,
|
|
"startChar": 19,
|
|
"endLine": 410,
|
|
"endChar": 23
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5bbf9cdd_1cb6968a",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "nit: resp isn\u0027t used, in the future this could be an unused variable error.\nMaybe use [1] instead?",
|
|
"range": {
|
|
"startLine": 413,
|
|
"startChar": 8,
|
|
"endLine": 413,
|
|
"endChar": 12
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4de23b00_89ecec0d",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Yep, will be fixed.",
|
|
"parentUuid": "5bbf9cdd_1cb6968a",
|
|
"range": {
|
|
"startLine": 413,
|
|
"startChar": 8,
|
|
"endLine": 413,
|
|
"endChar": 12
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2d1f5b8d_bcc76abb",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "4de23b00_89ecec0d",
|
|
"range": {
|
|
"startLine": 413,
|
|
"startChar": 8,
|
|
"endLine": 413,
|
|
"endChar": 12
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "520c036c_0294d82c",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 419,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "Same comment here, given this is the second recordset that counts against the quota in line 397, maybe this should be \"2nd\"?",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5e828619_30aa878d",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 419,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Yep, in fact this is the second one created for tenant, will fix that.",
|
|
"parentUuid": "520c036c_0294d82c",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0a063d92_6373a0df",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 419,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5e828619_30aa878d",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f7cdc010_260596ee",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 424,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This is not a zone, we should update this variable name for clarity.",
|
|
"range": {
|
|
"startLine": 424,
|
|
"startChar": 18,
|
|
"endLine": 424,
|
|
"endChar": 36
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b0dcd3a3_c67b5cff",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 424,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "OK, I\u0027ll rename it to quota_recset",
|
|
"parentUuid": "f7cdc010_260596ee",
|
|
"range": {
|
|
"startLine": 424,
|
|
"startChar": 18,
|
|
"endLine": 424,
|
|
"endChar": 36
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "14812cd9_2a49754c",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 424,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "b0dcd3a3_c67b5cff",
|
|
"range": {
|
|
"startLine": 424,
|
|
"startChar": 18,
|
|
"endLine": 424,
|
|
"endChar": 36
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3815c2e9_83332d72",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 437,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This pattern seems a bit odd. We are adding two cleanups for the same resource.\nIt also seems like the client should either return a response or raise an exception. Catching a generic Exception seems wrong.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "036ed7c9_e16dd462",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 437,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "I was trying to catch all possible options, therefore it looks a bit odd.\nAnyway, I think that asserting 413 will be enough here. I\u0027ll remove \"try except\" in the next patchset.",
|
|
"parentUuid": "3815c2e9_83332d72",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "27b377ee_d3f5b748",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 437,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "036ed7c9_e16dd462",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "11a404e1_b36fd16d",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 457,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This will need to be updated to zones_client",
|
|
"range": {
|
|
"startLine": 457,
|
|
"startChar": 20,
|
|
"endLine": 457,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "eaa530d5_f5324187",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 457,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T23:09:20Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "11a404e1_b36fd16d",
|
|
"range": {
|
|
"startLine": 457,
|
|
"startChar": 20,
|
|
"endLine": 457,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c4e0fb91_a0ac9f6d",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 468,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "Same here, I don\u0027t think we should be setting sudo here.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "08a47137_8b5311b2",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 468,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Same as in L401",
|
|
"parentUuid": "c4e0fb91_a0ac9f6d",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "eba1aa47_e4b02146",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 468,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "08a47137_8b5311b2",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2fc6f769_885e38fa",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 484,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This is not a zone, we should update this variable name for clarity.",
|
|
"range": {
|
|
"startLine": 484,
|
|
"startChar": 18,
|
|
"endLine": 484,
|
|
"endChar": 35
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b9f64bc3_295c84a3",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 484,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Same as in L424",
|
|
"parentUuid": "2fc6f769_885e38fa",
|
|
"range": {
|
|
"startLine": 484,
|
|
"startChar": 18,
|
|
"endLine": 484,
|
|
"endChar": 35
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0196a2f2_8175f032",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 484,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "b9f64bc3_295c84a3",
|
|
"range": {
|
|
"startLine": 484,
|
|
"startChar": 18,
|
|
"endLine": 484,
|
|
"endChar": 35
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6bf8ae76_65eebaa7",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 498,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This pattern seems a bit odd. We are adding two cleanups for the same resource.\nIt also seems like the client should either return a response or raise an exception. Catching a generic Exception seems wrong.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7f947db8_8a756ef8",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 498,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Same as in L437",
|
|
"parentUuid": "6bf8ae76_65eebaa7",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d2179401_9b3e38c2",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 498,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7f947db8_8a756ef8",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d7a6ecd0_e72b3bc6",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 521,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "Same here, I don\u0027t think we should be setting sudo here.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9a8e9bbd_d5a0d993",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 521,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Same as in L401",
|
|
"parentUuid": "d7a6ecd0_e72b3bc6",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "48e1d126_c451332a",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 521,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "9a8e9bbd_d5a0d993",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "810bade9_7cc5d675",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 526,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This will need to be updated to zones_client",
|
|
"range": {
|
|
"startLine": 526,
|
|
"startChar": 20,
|
|
"endLine": 526,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "01e2252c_9bfd4e00",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 526,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T23:09:20Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "810bade9_7cc5d675",
|
|
"range": {
|
|
"startLine": 526,
|
|
"startChar": 20,
|
|
"endLine": 526,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "96ddc28d_99d8223a",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 544,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This is not a zone, we should update this variable name for clarity.",
|
|
"range": {
|
|
"startLine": 544,
|
|
"startChar": 18,
|
|
"endLine": 544,
|
|
"endChar": 35
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "496a47e0_6a08caae",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 544,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "OK, I\u0027ll rename it to quota_recset",
|
|
"parentUuid": "96ddc28d_99d8223a",
|
|
"range": {
|
|
"startLine": 544,
|
|
"startChar": 18,
|
|
"endLine": 544,
|
|
"endChar": 35
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "708bb035_c2306287",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 544,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "496a47e0_6a08caae",
|
|
"range": {
|
|
"startLine": 544,
|
|
"startChar": 18,
|
|
"endLine": 544,
|
|
"endChar": 35
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2e8c77c0_daa48e35",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 558,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This pattern seems a bit odd. We are adding two cleanups for the same resource.\nIt also seems like the client should either return a response or raise an exception. Catching a generic Exception seems wrong.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "501db082_1afc0c15",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 558,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Same as in L437",
|
|
"parentUuid": "2e8c77c0_daa48e35",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e538c319_a184cea7",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 558,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "501db082_1afc0c15",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f5ac8769_f5dfa3c4",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 582,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "Same here, I don\u0027t think we should be setting sudo here.",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ddad90eb_f64f85f8",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 582,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-23T13:07:58Z",
|
|
"side": 1,
|
|
"message": "Same as in L401",
|
|
"parentUuid": "f5ac8769_f5dfa3c4",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4028706a_e4e63efa",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 582,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-04-16T15:04:56Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "ddad90eb_f64f85f8",
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9bf73c0a_882602f5",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 587,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T22:59:06Z",
|
|
"side": 1,
|
|
"message": "This will need to be updated to zones_client",
|
|
"range": {
|
|
"startLine": 587,
|
|
"startChar": 20,
|
|
"endLine": 587,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4317976e_259010fe",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 587,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2023-02-22T23:09:20Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "9bf73c0a_882602f5",
|
|
"range": {
|
|
"startLine": 587,
|
|
"startChar": 20,
|
|
"endLine": 587,
|
|
"endChar": 31
|
|
},
|
|
"revId": "43708debd53ce1f4b08bafa507d58c07048791b4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |