39764a0839
Change has been successfully merged
Patch-set: 1
Status: merged
Tag: autogenerated:gerrit:merged
Reviewer: Gerrit User 22348 <22348@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: SUBM=+1, a0eb92584c6ed0b3ec73934c748e9a7758645dbf
Submission-id: 901402-invalid_project
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: Verified: Gerrit User 22348 <22348@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Submitted-with: MAY: Code-Review: Gerrit User 31664 <31664@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Submitted-with: MAY: Workflow: Gerrit User 22623 <22623@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Submitted-with: MAY: Review-Priority
Attention: {"person_ident":"Gerrit User 7160 \u003c7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 5572 \u003c5572@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 28609 \u003c28609@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 19298 \u003c19298@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Change was submitted"}
231 lines
7.1 KiB
Plaintext
231 lines
7.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8aec489e_7bda633c",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-11-21T13:10:15Z",
|
|
"side": 1,
|
|
"message": "recheck\n\nFailures seems to be related to \"notify\" issue, recheck the results.",
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ed73692a_b1f0480a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-11-26T15:08:04Z",
|
|
"side": 1,
|
|
"message": "recheck",
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "846ac446_0899f72d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 30674
|
|
},
|
|
"writtenOn": "2023-11-30T10:57:36Z",
|
|
"side": 1,
|
|
"message": "Looks good to me! I would just add the negative attribute for the test.",
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b9d8b127_d02d08b9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31664
|
|
},
|
|
"writtenOn": "2023-12-04T12:25:23Z",
|
|
"side": 1,
|
|
"message": "Looks good to me",
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "100f6250_6b9099a4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 34067
|
|
},
|
|
"writtenOn": "2023-12-04T13:16:09Z",
|
|
"side": 1,
|
|
"message": "LGTM",
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0405abe7_cbd73eec",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2024-01-08T22:07:49Z",
|
|
"side": 1,
|
|
"message": "LGTM",
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4524faa4_b1515596",
|
|
"filename": "designate_tempest_plugin/tests/api/v2/test_zones.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 747,
|
|
"author": {
|
|
"id": 30674
|
|
},
|
|
"writtenOn": "2023-11-30T10:57:36Z",
|
|
"side": 1,
|
|
"message": "Negative tests in tempest should have the attribute \u0027negative\u0027 [1]. But I see that the other negative tests here are missing the flag as well.\n\n[1] https://docs.openstack.org/tempest/latest/HACKING.html#negative-attribute",
|
|
"range": {
|
|
"startLine": 747,
|
|
"startChar": 0,
|
|
"endLine": 747,
|
|
"endChar": 2
|
|
},
|
|
"revId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
],
|
|
"submitRequirementResults": [
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Code-Review",
|
|
"description": {
|
|
"value": "Code reviewed by core reviewer"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Review-Priority",
|
|
"description": {
|
|
"value": "Review priority"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "-label:Review-Priority\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"-label:Review-Priority=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Review-Priority=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Verified",
|
|
"description": {
|
|
"value": "Verified in gate by CI"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Workflow",
|
|
"description": {
|
|
"value": "Approved for gate by core reviewer"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "2c4210966b1458ed1a35c065c448f168f11c7277",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
}
|
|
]
|
|
} |