openstack
/
designate-tempest-plugin
Code Issues Proposed changes
designate-tempest-plugin/6aeed0d90567408179b4ea31987...

212 lines
8.8 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "cebd3e00_8b7e8c23",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 28609
},
"writtenOn": "2022-08-09T09:34:20Z",
"side": 1,
"message": "recheck \nRecreating results",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a1e2a4b3_666fe4f9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 28609
},
"writtenOn": "2022-12-29T08:22:39Z",
"side": 1,
"message": "recheck",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "eebffe68_a6e3f7ae",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 5572
},
"writtenOn": "2023-01-11T19:21:57Z",
"side": 1,
"message": "See comment:",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b5870352_d0100335",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 28609
},
"writtenOn": "2023-04-16T16:31:35Z",
"side": 1,
"message": "recheck",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a1ddcd10_eca12843",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 28609
},
"writtenOn": "2023-06-20T09:09:22Z",
"side": 1,
"message": "recheck",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4eafe263_3554f8fb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 19298
},
"writtenOn": "2023-07-20T11:47:45Z",
"side": 1,
"message": "The implementation has incorrect behavior for some edge cases.",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a29cc03a_9e8c793a",
"filename": "designate_tempest_plugin/data_utils.py",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 5572
},
"writtenOn": "2023-01-11T19:21:57Z",
"side": 1,
"message": "Not sure I follow this, but no matter what the name_size is it is returned to the caller, the label_size doesne\u0027t seem to limit the return value. I\u0027m assuming that the label_size as stated should return the name_size if \u003c or \u003d to label_size?\n\nFor example:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n zn \u003d rand_dns_name_by_size(263)\n print(\"zn: %s:%d\" % (zn, len(zn)))\n \n returns:\n 263\n \n /u02/devl/RedHat/t1.py(36)main()\n-\u003e zn \u003d rand_dns_name_by_size(263)\n(Pdb) n\n\u003e /u02/devl/RedHat/t1.py(37)main()\n-\u003e print(\"zn: %s:%d\" % (zn, len(zn)))\n(Pdb) \nzn: xrkchnjvsdsongvmjxjcxhleubgedjtazqkuvjdhgvfifvvchwfaiwaertwddbp.mljhyiylavndfagytopoogsjlmrkljoattknyanugfuzqpeoikqemgnmllsmhtf.mhooxnedllxvlgfyipkvxucsibrxoccyerkrauxsrnkpmjjutkopqtwdhmwvfbm.tkskzcimlvytlrnpljexmnsrzzwssmtnorhexlhvallttngyrfsedpxzxvbddks.smfcnk.:263\n\u003e /u02/devl/RedHat/t1.py(38)main()\n-\u003e zn \u003d rand_dns_name_by_size(6)\n(Pdb) \n\u003e /u02/devl/RedHat/t1.py(39)main()\n-\u003e print(\"zn: %s:%d\" % (zn, len(zn)))\n(Pdb) \nzn: zhcbq.:6\n\u003e /u02/devl/RedHat/t1.py(40)main()\n-\u003e zn \u003d rand_dns_name_by_size(63)\n(Pdb) \n\u003e /u02/devl/RedHat/t1.py(41)main()\n-\u003e print(\"zn: %s:%d\" % (zn, len(zn)))\n(Pdb) \nzn: zeorlqsyzxruqcpxtrvwufbhaapihaeqherhewrrseqnvrznhiowjbufpfhshx.:63\n\u003e /u02/devl/RedHat/t1.py(43)main()",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b7af5007_7291b1a6",
"filename": "designate_tempest_plugin/data_utils.py",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 28609
},
"writtenOn": "2023-02-07T10:06:19Z",
"side": 1,
"message": "Hi Don!\n\nI don\u0027t understand what\u0027s wrong here 😞\nThis function gets 2 parameters: name _size and label_size, the last (label) is set to 63 by default.\n\nHere are my attempts and all looks good to me:\n\n### Test Code ###\nprint(\u002710,3\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(10,3))\nprint(\u002720,5\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(20,5))\nprint(\u002740,10\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(40,10))\nprint(\u002750,15\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(50,15))\n\n\n### Prompted Output ###\n10,3\nccj.adf.j.\n20,5\nefyuu.rpjst.medkr.j.\n40,10\nyvahqqowyp.gdhzbothjz.gwwltlbeof.ijehrh.\n50,15\nfzomapovewzydan.pbjhzdfqzdqpapa.dwifprwrywqpdih.e.\n\nThanks!",
"parentUuid": "a29cc03a_9e8c793a",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "55dffa98_0d967b71",
"filename": "designate_tempest_plugin/data_utils.py",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 28609
},
"writtenOn": "2023-02-07T10:06:36Z",
"side": 1,
"message": "Done",
"parentUuid": "b7af5007_7291b1a6",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5d03416a_cece9bc1",
"filename": "designate_tempest_plugin/data_utils.py",
"patchSetId": 5
},
"lineNbr": 70,
"author": {
"id": 19298
},
"writtenOn": "2023-07-20T11:47:45Z",
"side": 1,
"message": "Your implementation has edge cases that produce illegal results. For example,\n\nrand_dns_name_by_size(5, 3) -\u003e nsq..\n\nYou can simplify this implementation:\n\n```python\ndef rand_dns_name_by_size(name_size, label_size\u003d63):\n \"\"\"Generates label based DNS name with limited total size\n :param name_size: maximum total size in characters\n :param label_size: the maximum number of characters to be used\n per label. Max value according the RFC is 63\n https://datatracker.ietf.org/doc/html/rfc1035#\n section-2.3.4in\n :return: DNS name\n \"\"\"\n template \u003d \u0027\u0027\n while len(template) \u003c name_size:\n remaining_length \u003d name_size - len(template)\n template +\u003d \u0027{}.\u0027.format(rand_string(min(remaining_length, label_size)))\n return template\n```",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c0ddd333_da1a9d5c",
"filename": "designate_tempest_plugin/data_utils.py",
"patchSetId": 5
},
"lineNbr": 70,
"author": {
"id": 28609
},
"writtenOn": "2023-07-23T14:44:31Z",
"side": 1,
"message": "Yep, this code is much more simple, I just added:\n1) \"-1\" here: min(remaining_length - 1, label_size)))to discount the dot.\n2) Raise exception. In some cases we simply cannot generate a valid DNS name, for \n example: rand_dns_name_by_size(10,2) --\u003e dp.qm.cp..\n So it will now throw the exception, asking developer changing the values.",
"parentUuid": "5d03416a_cece9bc1",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "31f01e26_2136dc1f",
"filename": "designate_tempest_plugin/data_utils.py",
"patchSetId": 5
},
"lineNbr": 70,
"author": {
"id": 28609
},
"writtenOn": "2023-07-23T14:44:42Z",
"side": 1,
"message": "Done",
"parentUuid": "c0ddd333_da1a9d5c",
"revId": "6aeed0d90567408179b4ea319871b789e8d75970",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink