55aaa48796
Patch Set 1: (4 comments) Patch-set: 1 CC: Gerrit User 28609 <28609@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
130 lines
4.3 KiB
Plaintext
130 lines
4.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e2c6929d_6936344b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11628
|
|
},
|
|
"writtenOn": "2022-09-10T00:11:28Z",
|
|
"side": 1,
|
|
"message": "For this to really be useful we will need shared zones.\nThis patch needs to be updated.",
|
|
"revId": "f68e6cb07adbe2f0bedca121eca4b87bd1e203e5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2c74dab7_b1a74fce",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 5572
|
|
},
|
|
"writtenOn": "2022-09-17T19:57:16Z",
|
|
"side": 1,
|
|
"message": "LGTM\nall-plugin run-test: commands[3] | tempest run --regex designate_tempest_plugin.tests.scenario.v2.test_classless_ptr\n{0} designate_tempest_plugin.tests.scenario.v2.test_classless_ptr.ClasslessPTRTest.test_classless_ptr_delegation [42.220630s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 42.2206 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 42.2206 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (1 tests) \u003d\u003e 0:00:42.220630\n",
|
|
"revId": "f68e6cb07adbe2f0bedca121eca4b87bd1e203e5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "54032764_490eafa0",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_classless_ptr.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 75,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-12T10:25:25Z",
|
|
"side": 1,
|
|
"message": "Nit\nYou can use \"wait_until\u003d\u0027ACTIVE\u0027\" in L70 instead of having this code line.",
|
|
"range": {
|
|
"startLine": 74,
|
|
"startChar": 0,
|
|
"endLine": 75,
|
|
"endChar": 50
|
|
},
|
|
"revId": "f68e6cb07adbe2f0bedca121eca4b87bd1e203e5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6c8c3ee8_15ed8434",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_classless_ptr.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 85,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-12T10:25:25Z",
|
|
"side": 1,
|
|
"message": "Same as in L74",
|
|
"range": {
|
|
"startLine": 84,
|
|
"startChar": 0,
|
|
"endLine": 85,
|
|
"endChar": 50
|
|
},
|
|
"revId": "f68e6cb07adbe2f0bedca121eca4b87bd1e203e5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "43c13bd6_cbb068e0",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_classless_ptr.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 101,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-12T10:25:25Z",
|
|
"side": 1,
|
|
"message": "Nit\nIt\u0027s the same about create_recordset, is also callable with:\" wait_until\u003dconst.ACTIVE\", so you can remove this line if use add this into L93",
|
|
"range": {
|
|
"startLine": 99,
|
|
"startChar": 0,
|
|
"endLine": 101,
|
|
"endChar": 46
|
|
},
|
|
"revId": "f68e6cb07adbe2f0bedca121eca4b87bd1e203e5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "83cec61a_946d6bdc",
|
|
"filename": "designate_tempest_plugin/tests/scenario/v2/test_classless_ptr.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 117,
|
|
"author": {
|
|
"id": 28609
|
|
},
|
|
"writtenOn": "2023-02-12T10:25:25Z",
|
|
"side": 1,
|
|
"message": "Same as in L99",
|
|
"range": {
|
|
"startLine": 115,
|
|
"startChar": 0,
|
|
"endLine": 117,
|
|
"endChar": 25
|
|
},
|
|
"revId": "f68e6cb07adbe2f0bedca121eca4b87bd1e203e5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |