openstack
/
designate
Code Issues Proposed changes

Update patch set 8 

Patch Set 8:

(2 comments)

Patch-set: 8
This commit is contained in:
Gerrit User 32919 2023-03-21 14:42:30 +00:00 committed by Gerrit Code Review
parent cf262695e1
commit fe5b01d001
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1
View File

@ -89,6 +89,24 @@
"revId": "2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "75659c4f_f9e36916",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 32919
},
"writtenOn": "2023-03-21T14:42:30Z",
"side": 1,
"message": "I had mentioned issues with this approach earlier https://review.opendev.org/c/openstack/designate/+/866698/comments/8bac2428_6de72227",
"parentUuid": "f0c2f782_8dc55899",
"revId": "2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

18
36add1d78a748af671b326833d37f4954afc6294
View File

@ -16,6 +16,24 @@
"message": "This will need to be added to the database as well using alembic.",
"revId": "36add1d78a748af671b326833d37f4954afc6294",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f2daf39a_6ba3df8f",
"filename": "designate/storage/impl_sqlalchemy/tables.py",
"patchSetId": 8
},
"lineNbr": 45,
"author": {
"id": 32919
},
"writtenOn": "2023-03-21T14:42:30Z",
"side": 1,
"message": "updated",
"parentUuid": "c20dccd8_f381167b",
"revId": "36add1d78a748af671b326833d37f4954afc6294",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}