openstack/devstack-gate
Code Issues Proposed changes

Add a comment for ERROR_ON_CLONE

Browse Source 
Devstack is currently supporting plugins. As some authors write
plugins they try various ways of solving their issue. One author
tried to set the value of ERROR_ON_CLONE to FALSE to get their
plugin to work. OpenStack gate needs this variable to remain
with the value of TRUE.

Trying to create a devstack plugin by setting this variable to
FALSE is the wrong approach.

Change-Id: I9c53980629554ade123381909a9fc6f60666baf7
Reference: https://review.openstack.org/#/c/158075/1
This commit is contained in:
Anita Kuno
2015-02-23 14:41:04 -05:00
parent 57be7c262e
commit 4b0f1dc31c
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
devstack-vm-gate.sh
View File

@@ -127,6 +127,11 @@ SERVICE_PASSWORD=secretservice
SERVICE_TOKEN=111222333444
SWIFT_HASH=1234123412341234
ROOTSLEEP=0
# ERROR_ON_CLONE should never be set to FALSE in gate jobs.
# Setting up git trees must be done by zuul
# because it needs specific git references directly from gerrit
# to correctly do testing. Otherwise you are not testing
# the code you have posted for review.
ERROR_ON_CLONE=True
ENABLED_SERVICES=$MY_ENABLED_SERVICES
SKIP_EXERCISES=$SKIP_EXERCISES