Update patch set 28

Patch Set 28:

(1 comment)

Patch-set: 28
Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
Gerrit User 16643 2023-05-23 20:03:52 +00:00 committed by Gerrit Code Review
parent de99017369
commit b0e542a236
1 changed files with 18 additions and 0 deletions

View File

@ -71,6 +71,24 @@
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6bc4cf2a_93dbc1b2",
"filename": "devstack/lib/cephadm",
"patchSetId": 25
},
"lineNbr": 136,
"author": {
"id": 16643
},
"writtenOn": "2023-05-23T20:03:52Z",
"side": 1,
"message": "That\u0027s a good point. \n\nwe were trying to design this with devstack\u0027s install phases.. i.e., \"install\" will cause the creation of the ceph cluster and \"post-config\" will cause creation of the ceph resources and configuration required by devstack\u0027s services.. \n\nansiblizing this would be cleaner; but if we stick to this approach, it would require us to enhance devstack so that \"stack.sh\" can be invoked to run those install phases on demand: \n\n\n - ./stack.sh -p override_defaults\n - ./stack.sh -p source\n - ./stack.sh -p pre-install\n - ./stack.sh -p install \n - wait for ceph to be ready\n - ./stack.sh -p post-config\n - ./stack.sh -p extra\n - ./stack.sh -p test-config\n \n\nThis would be a good improvement for CI, but also limit our ability to do this locally without similar smarts",
"parentUuid": "1bdb1c66_24511584",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {