Update patch set 47

Patch Set 47:

(7 comments)

Patch-set: 47
Attention: {"person_ident":"Gerrit User 32594 \u003c32594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
This commit is contained in:
Gerrit User 32594 2023-08-07 20:11:14 +00:00 committed by Gerrit Code Review
parent 7c954be3ef
commit b681f164ec
4 changed files with 147 additions and 0 deletions

View File

@ -23,6 +23,30 @@
"revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3041ecc7_9ce8eb63",
"filename": "/COMMIT_MSG",
"patchSetId": 46
},
"lineNbr": 17,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 1,
"message": "Done",
"parentUuid": "9ebdc910_e9344f4d",
"range": {
"startLine": 17,
"startChar": 10,
"endLine": 17,
"endChar": 52
},
"revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -127,6 +151,24 @@
"revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "583efe9f_d1d2cdf8",
"filename": "devstack/lib/cephadm",
"patchSetId": 46
},
"lineNbr": 127,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 1,
"message": "Done",
"parentUuid": "868555bb_a16c2573",
"revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -143,6 +185,24 @@
"message": "Unrelated whitespace damage",
"revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "447cde06_8e87c500",
"filename": "devstack/lib/cephadm",
"patchSetId": 46
},
"lineNbr": 652,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 1,
"message": "Done",
"parentUuid": "b4a49e81_11dcd02e",
"revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -23,6 +23,30 @@
"revId": "96ef1e49d06839928372b1b99f8d0b60bbfa8df4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6ffd57ae_1fd58697",
"filename": ".zuul.yaml",
"patchSetId": 44
},
"lineNbr": 171,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 1,
"message": "Done",
"parentUuid": "41521199_64637bfd",
"range": {
"startLine": 171,
"startChar": 0,
"endLine": 171,
"endChar": 45
},
"revId": "96ef1e49d06839928372b1b99f8d0b60bbfa8df4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "96ef1e49d06839928372b1b99f8d0b60bbfa8df4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "62d7e6aa_242f6955",
"filename": ".zuul.yaml",
"patchSetId": 44
},
"lineNbr": 175,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 1,
"message": "Done",
"parentUuid": "fc8a02de_f92daebe",
"range": {
"startLine": 174,
"startChar": 0,
"endLine": 175,
"endChar": 47
},
"revId": "96ef1e49d06839928372b1b99f8d0b60bbfa8df4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "1bca2dd2_859ac0c0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 47
},
"lineNbr": 0,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 1,
"message": "Thanks for the reviews!",
"revId": "a424a5eaf0b2afd74f5db65773366793ed7c2a84",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -86,6 +86,24 @@
"message": "As I mentioned before, I\u0027d prefer not to build the sudo into the command variable itself so it\u0027s clear when and where we\u0027re running this with sudo. Since this is already the case, making this change just clouds the rest of the change here. Even if we\u0027re going to do this, I\u0027d rather it be part of a cleanup patch than one that changes the way this all works.",
"revId": "bdce6ce508671b9fb6be7825c8c244e742895362",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c2e3611b_46d6ff9e",
"filename": "devstack/lib/cephadm",
"patchSetId": 46
},
"lineNbr": 101,
"author": {
"id": 32594
},
"writtenOn": "2023-08-07T20:11:14Z",
"side": 0,
"message": "Done",
"parentUuid": "cfadf365_497f5753",
"revId": "bdce6ce508671b9fb6be7825c8c244e742895362",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}