openstack/devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 3

Browse Source 
Patch Set 3:

(1 comment)

Patch-set: 3
This commit is contained in:
Gerrit User 4690 2023-09-16 21:53:54 +00:00 committed by Gerrit Code Review
parent 0d2c374f6f
commit b9e7a93e8e
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
8e974c9d524f54a73a75b676a904d622257716de Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "9af39871_fce4ef00",
"filename": "devstack/lib/ceph",
"patchSetId": 3
},
"lineNbr": 129,
"author": {
"id": 4690
},
"writtenOn": "2023-09-16T21:53:54Z",
"side": 1,
"message": "Note to reviewers: I took this approach in an effort to minimize the potential for \"incorrect config\" and make it simple to understand for users.\n\nInitially I had instead something like `CINDER_CEPH_POOL_NUM` meaning how many Ceph pools to create, but that has the disadvantage of being about to go out of sync with the number of Ceph backends in `CINDER_ENABLED_BACKENDS`. I didn\u0027t want users to have to make sure `CINDER_ENABLED_BACKENDS` and `CINDER_CEPH_POOL_NUM` match.\n\nSo with this the user can indicate whether they would like a separate Ceph pool per Ceph backend in `CINDER_ENABLED_BACKENDS` or if they would prefer for all the backends to share the same `CINDER_CEPH_POOL` (current behavior).",
"revId": "8e974c9d524f54a73a75b676a904d622257716de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}