68306ddff5
Patch Set 44: (9 comments) Patch-set: 44 Attention: {"person_ident":"Gerrit User 32594 \u003c32594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
162 lines
4.3 KiB
Plaintext
162 lines
4.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b75122a0_8c0245e3",
|
|
"filename": ".zuul.yaml",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 167,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2023-07-20T23:54:29Z",
|
|
"side": 1,
|
|
"message": "can you please replace this job to use cephadm instead? you can delete the other job altogether; and this can remain \"non-voting\"\n\n\nSo the intent of this change is to replace the existing multinode job to use cephadm instead of the package based installation. That\u0027s what we\u0027ve essentially done with the single node job above (\"devstack-plugin-ceph-tempest-py3\")",
|
|
"range": {
|
|
"startLine": 166,
|
|
"startChar": 10,
|
|
"endLine": 167,
|
|
"endChar": 25
|
|
},
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "659a272a_e58a618b",
|
|
"filename": ".zuul.yaml",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 167,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2023-07-24T19:07:16Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "b75122a0_8c0245e3",
|
|
"range": {
|
|
"startLine": 166,
|
|
"startChar": 10,
|
|
"endLine": 167,
|
|
"endChar": 25
|
|
},
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6f3839db_b7aadd11",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2023-07-20T23:54:29Z",
|
|
"side": 1,
|
|
"message": "drop",
|
|
"range": {
|
|
"startLine": 7,
|
|
"startChar": 0,
|
|
"endLine": 7,
|
|
"endChar": 11
|
|
},
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4add9670_19cd8d6b",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2023-07-24T19:07:16Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "6f3839db_b7aadd11",
|
|
"range": {
|
|
"startLine": 7,
|
|
"startChar": 0,
|
|
"endLine": 7,
|
|
"endChar": 11
|
|
},
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e944cdab_28d433fa",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2023-07-20T23:54:29Z",
|
|
"side": 1,
|
|
"message": "Great to see this job pass! Good work on this Ashley; imo, just a bit more cleanup to close this out",
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cedee1a2_3147386e",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 673,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2023-07-20T23:54:29Z",
|
|
"side": 1,
|
|
"message": "nit: skipping",
|
|
"range": {
|
|
"startLine": 673,
|
|
"startChar": 35,
|
|
"endLine": 673,
|
|
"endChar": 39
|
|
},
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e6459c10_ace4fed6",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 43
|
|
},
|
|
"lineNbr": 673,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2023-07-24T19:07:16Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "cedee1a2_3147386e",
|
|
"range": {
|
|
"startLine": 673,
|
|
"startChar": 35,
|
|
"endLine": 673,
|
|
"endChar": 39
|
|
},
|
|
"revId": "c4486eb7b79a9a15c5b80d301ebd23681d9d4030",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |