4106731813
Patch Set 8:
(2 comments)
Patch-set: 8
Attention: {"person_ident":"Gerrit User 25402 \u003c25402@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32594 \u003c32594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
108 lines
4.0 KiB
Plaintext
108 lines
4.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7fc13f1b_a0134f43",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2023-11-15T17:02:09Z",
|
|
"side": 1,
|
|
"message": "recheck",
|
|
"revId": "fac55d15453d7666a1a63d53d128bf826425817d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2e9c994f_9b153a99",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2023-11-15T20:09:58Z",
|
|
"side": 1,
|
|
"message": "I think this patch addresses several issues at once; and we should get this in before we fix the others... i see a couple of issues here:\n\n1) The CephFS/NFS job is failing because of a different issue; and is unrelated to this change... that job uses the default \"package-based\" installation of ceph, and not cephadm... the problem with the job seems to be related to https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/HVFN5RBSHRTM3B2UUKPAWKH6H6AT6CYR/\n\nWe have this problem in all branches; we need to fix that up everywhere.\n\n\n2) The CephFS-Native job seems to be failing consistently to setup the tempest virtualenv... devstack, ceph and manila setup seems to work just fine here.. i\u0027m okay with investigating that as a separate issue since, the changes in this patch\n- allow the use of cephadm on Jammy\n- allow the use of cephadm in multinode jobs\nthe first one affects this specific job; and that part is working.. lets triage the failure separately and fix it.\n\nThanks Ashley!",
|
|
"revId": "fac55d15453d7666a1a63d53d128bf826425817d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d8571bf0_393c4aca",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 37,
|
|
"author": {
|
|
"id": 25402
|
|
},
|
|
"writtenOn": "2023-11-16T08:44:10Z",
|
|
"side": 1,
|
|
"message": "you can probably simplify this with:\n\n```\nFSID\u003d$(cat ceph.conf | awk \u0027/fsid/ { print $3 }\u0027)\n```",
|
|
"revId": "fac55d15453d7666a1a63d53d128bf826425817d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6d26b4af_95d8bad2",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 37,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2023-12-04T16:39:42Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "d8571bf0_393c4aca",
|
|
"revId": "fac55d15453d7666a1a63d53d128bf826425817d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9919f44f_8c60f6af",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 672,
|
|
"author": {
|
|
"id": 25402
|
|
},
|
|
"writtenOn": "2023-11-16T08:44:10Z",
|
|
"side": 1,
|
|
"message": "nit: \n\nwhy not:\n\n```\nif [[ \"$REMOTE_CEPH\" \u003d\u003d \"False\" ]]; then\n stop_ceph\n delete_osds\nfi\n```\n\nand save an `else` statement? (anyway not a blocking thing)",
|
|
"revId": "fac55d15453d7666a1a63d53d128bf826425817d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "24af4dc4_371a12a3",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 672,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2023-12-04T16:39:42Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "9919f44f_8c60f6af",
|
|
"revId": "fac55d15453d7666a1a63d53d128bf826425817d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |