devstack-plugin-ceph/94b582261cc795407188a0479439f36715210691

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "b976f754_1c80ca65",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 136,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-23T14:19:03Z",
      "side": 1,
      "message": "Why are you doing this? I think it\u0027d be better to leave it the way it is - have `CEPHADM` be the actual path to the tool and call it with `sudo` when appropriate (even if it\u0027s always).",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e7bdde55_9d73f8a1",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 136,
      "author": {
        "id": 32594
      },
      "writtenOn": "2023-05-23T17:02:22Z",
      "side": 1,
      "message": "In the case that remote_ceph is true, the command to get to cephadm shell is \"ssh $SSH_USER@$CEPH_IP sudo ${TARGET_BIN}/cephadm\" and that is what im using as $CEPHADM. I need sudo to be part of the command othewise I cant reuse CEPHADM as the situation calls. good thing is that cephadm is /always/ called with sudo so its an easy thing to do.",
      "parentUuid": "b976f754_1c80ca65",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "24cf2225_bc832786",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 136,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-23T17:32:30Z",
      "side": 1,
      "message": "I think you should explicitly put the sudo in the ssh command. However, I still think sshing between the nodes like this is less ideal than letting ansible copy the things that we need (like has been the case for this job for a while).\n\nWhy do you need to ssh to the main node to run `cephadm` commands? Before we just needed ceph config and keys (right?)... what else needs to get run?\n\nPersonally I think that wrapping cephadm in an ssh-to-main-node is likely to be confusing.",
      "parentUuid": "e7bdde55_9d73f8a1",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ab39a40c_0d25f0bf",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 510,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-23T14:19:03Z",
      "side": 1,
      "message": "Running cat as sudo will not allow it to write to `$CEPH_CONF_DIR` because the file is actually opened by the shell. You want something like:\n```\ncat \u003c\u003cEOF | sudo tee $CEPH_CONF_DIR/$CEPH_CLUSTER_IS_READY.txt\n...\n```\nHowever since you only seem to care that it\u0027s created, you might as well just:\n```\nsudo touch $CEPH_CONF_DIR/$CEPH_CLUSTER_IS_READY.txt\n```",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "dc2c6e72_ce133342",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 510,
      "author": {
        "id": 32594
      },
      "writtenOn": "2023-05-23T17:02:22Z",
      "side": 1,
      "message": "ah yes this makes sense, thanks. Havent worked with bash script before this, so I\u0027m learning as  go",
      "parentUuid": "ab39a40c_0d25f0bf",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "72f57bfb_0c379175",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 515,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-23T14:19:03Z",
      "side": 1,
      "message": "Where is this called from?\n\nI assume it\u0027s going to be from the subnode to the master one? I\u0027m not sure this polling over ssh is really the best way to do it, but I\u0027d have to ask.",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "897ee047_856587a5",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 515,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-23T14:46:02Z",
      "side": 1,
      "message": "Yeah, so I think we already have a way to make sure the ceph.conf gets copied from the master node to the subnode:\n\nhttps://opendev.org/openstack/devstack/src/branch/master/roles/sync-controller-ceph-conf-and-keys/tasks/main.yaml\n\nAFAIK, that\u0027s how it happens for the current package-based case. Doing this manually in this code is likely to be less reliable I think.",
      "parentUuid": "72f57bfb_0c379175",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4d83021d_800b9904",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 515,
      "author": {
        "id": 32594
      },
      "writtenOn": "2023-05-23T17:02:22Z",
      "side": 1,
      "message": "So the thought process here is that when the master and subnode are created in parallel like in the case of zuul ci, I need to make sure the node with manila (subnode) waits until ceph is ready on master. this is more to have a waiter than to copy ceph.conf. though that does happen later in post-config",
      "parentUuid": "897ee047_856587a5",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "2e17fb88_513b31db",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 25
      },
      "lineNbr": 515,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-23T17:32:30Z",
      "side": 1,
      "message": "Yeah I understand that\u0027s what this code inside the function is doing. What I was saying is I don\u0027t see that it actually gets called anywhere. However, I see the call is in `plugin.sh`.",
      "parentUuid": "4d83021d_800b9904",
      "revId": "94b582261cc795407188a0479439f36715210691",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}