devstack-plugin-ceph/442ff1d7b0ce6347a45cbac247b34213557b710d

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "9ebdc910_e9344f4d",
        "filename": "/COMMIT_MSG",
        "patchSetId": 46
      },
      "lineNbr": 17,
      "author": {
        "id": 16643
      },
      "writtenOn": "2023-07-25T23:40:43Z",
      "side": 1,
      "message": "This should be I5162815b66d3f3e8cf8c1e246b61b0ea06c1a270 now",
      "range": {
        "startLine": 17,
        "startChar": 10,
        "endLine": 17,
        "endChar": 52
      },
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "3041ecc7_9ce8eb63",
        "filename": "/COMMIT_MSG",
        "patchSetId": 46
      },
      "lineNbr": 17,
      "author": {
        "id": 32594
      },
      "writtenOn": "2023-08-07T20:11:14Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "9ebdc910_e9344f4d",
      "range": {
        "startLine": 17,
        "startChar": 10,
        "endLine": 17,
        "endChar": 52
      },
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "cf6f0326_ae82001d",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 46
      },
      "lineNbr": 0,
      "author": {
        "id": 16643
      },
      "writtenOn": "2023-07-24T21:52:14Z",
      "side": 1,
      "message": "\u003e mapping values are not allowed in this context\n\u003e in \"openstack/devstack-plugin-ceph/.zuul.yaml@master\", line 172, column 19\n\nMade a minor edit to fix this up",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "01cf61ae_3da6cfcd",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 46
      },
      "lineNbr": 0,
      "author": {
        "id": 16643
      },
      "writtenOn": "2023-07-25T23:39:53Z",
      "side": 1,
      "message": "Works; LGTM, thank you!",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "79c4772a_ef760f96",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 46
      },
      "lineNbr": 0,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-07-26T19:45:33Z",
      "side": 1,
      "message": "I haven\u0027t looked at this in detail, but here are a few comments from a skim. Probably need to get some of the devstack heavy(er) hitter to look at this before a nobody like me :)",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "0b1ef466_5e81dc48",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 46
      },
      "lineNbr": 127,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-07-26T19:45:33Z",
      "side": 1,
      "message": "This is minor, but can\u0027t we do this above the if for both cases and only do the python deps if REMOTE_CEPH\u003d\u003dFalse? It\u0027ll just eliminate the duplicate package list for future maintenance.",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "8de316dd_3d27db43",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 46
      },
      "lineNbr": 127,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-07-26T19:47:26Z",
      "side": 1,
      "message": "And also, why aren\u0027t these just in the package files like podman et al?",
      "parentUuid": "0b1ef466_5e81dc48",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "868555bb_a16c2573",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 46
      },
      "lineNbr": 127,
      "author": {
        "id": 16643
      },
      "writtenOn": "2023-07-26T20:13:28Z",
      "side": 1,
      "message": "+1 ack; i\u0027d prefer that too\n\nWill let Ashley pursue these changes ..",
      "parentUuid": "8de316dd_3d27db43",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "583efe9f_d1d2cdf8",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 46
      },
      "lineNbr": 127,
      "author": {
        "id": 32594
      },
      "writtenOn": "2023-08-07T20:11:14Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "868555bb_a16c2573",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "b4a49e81_11dcd02e",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 46
      },
      "lineNbr": 652,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-07-26T19:45:33Z",
      "side": 1,
      "message": "Unrelated whitespace damage",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "447cde06_8e87c500",
        "filename": "devstack/lib/cephadm",
        "patchSetId": 46
      },
      "lineNbr": 652,
      "author": {
        "id": 32594
      },
      "writtenOn": "2023-08-07T20:11:14Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "b4a49e81_11dcd02e",
      "revId": "442ff1d7b0ce6347a45cbac247b34213557b710d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}