openstack
/
devstack-plugin-ceph
Code Issues Proposed changes
devstack-plugin-ceph/bb523234a4fcbd4ee02a8427b28...

451 lines
13 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "4836ec43_e7e8ba33",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 19
},
"lineNbr": 0,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "Hi Ashley, please see comments inline. \n\nWhile you\u0027re experimenting, could you also disable jobs here that don\u0027t test your changes.. keep the cephadm jobs so they can tell you if you\u0027re breaking anything... grep the zuul config for CEPHADM_DEPLOY; you can re-enable them once you\u0027re past the experimentation..",
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d3bf1a1e_58d1357c",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 508,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "call this \"CEPH_CLUSTER_IS_READY\"",
"range": {
"startLine": 508,
"startChar": 31,
"endLine": 508,
"endChar": 42
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5920db7f_8a6d516a",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 508,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "d3bf1a1e_58d1357c",
"range": {
"startLine": 508,
"startChar": 31,
"endLine": 508,
"endChar": 42
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b3dad88c_8f46a0e9",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 509,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "Cluster is provisioned.",
"range": {
"startLine": 509,
"startChar": 0,
"endLine": 509,
"endChar": 21
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "277f924a_18d09f10",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 509,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "b3dad88c_8f46a0e9",
"range": {
"startLine": 509,
"startChar": 0,
"endLine": 509,
"endChar": 21
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e1cad01b_cfee0741",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 518,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "this variable isn\u0027t defined...",
"range": {
"startLine": 518,
"startChar": 11,
"endLine": 518,
"endChar": 18
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a43df592_c0f01b67",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 518,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "e1cad01b_cfee0741",
"range": {
"startLine": 518,
"startChar": 11,
"endLine": 518,
"endChar": 18
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9a91b466_96a1a863",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 661,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "We should allow the SSH user to be configured as well.. I think in Zuul/nodepool, the \"stack\" user is created as part of bootstrap, and there\u0027s no key exchange happening. You should rely on the zuul user perhaps.. So make this configurable, and plumb that in via the job config",
"range": {
"startLine": 661,
"startChar": 8,
"endLine": 661,
"endChar": 29
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "55dad7f0_433dfd53",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 661,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "9a91b466_96a1a863",
"range": {
"startLine": 661,
"startChar": 8,
"endLine": 661,
"endChar": 29
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e85f771d_ce43bd0e",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 680,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:56:25Z",
"side": 1,
"message": "this needs to be skipped when REMOTE_CEPH is True",
"range": {
"startLine": 679,
"startChar": 0,
"endLine": 680,
"endChar": 18
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9e5cc5cf_86d847f7",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 680,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "e85f771d_ce43bd0e",
"range": {
"startLine": 679,
"startChar": 0,
"endLine": 680,
"endChar": 18
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0e464f0c_6d57f807",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 681,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:56:25Z",
"side": 1,
"message": "You\u0027ll also need to delete the marker file you\u0027re creating here: https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747/19/devstack/lib/cephadm#508",
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "eb919c9e_7eddf420",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 681,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "unfamiliar with bash, but if its using rm -f /* is that force removing every file within that directory? if so, it should be removed automatically since Ive created it within ceph_conf_dir",
"parentUuid": "0e464f0c_6d57f807",
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2bc88c94_ead15746",
"filename": "devstack/lib/cephadm",
"patchSetId": 19
},
"lineNbr": 681,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T20:55:41Z",
"side": 1,
"message": "yeah, that should suffice; thanks!",
"parentUuid": "eb919c9e_7eddf420",
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6899cbb2_a50d22d9",
"filename": "devstack/plugin.sh",
"patchSetId": 19
},
"lineNbr": 43,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "This variable, \"REMOTE_CEPH\" doesn\u0027t have a default; so the script is just skipping onto the \"else\" part here (lines 59-60): https://zuul.opendev.org/t/openstack/build/ddfeeaa802cb4be0bef46aab36ce114e/log/job-output.txt#11800\n\nYou need to set the default for this in the settings file or the override_defaults file: https://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/override-defaults",
"range": {
"startLine": 43,
"startChar": 40,
"endLine": 43,
"endChar": 64
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b276c96a_961f2bfe",
"filename": "devstack/plugin.sh",
"patchSetId": 19
},
"lineNbr": 43,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "6899cbb2_a50d22d9",
"range": {
"startLine": 43,
"startChar": 40,
"endLine": 43,
"endChar": 64
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b189feec_0f8cf30e",
"filename": "devstack/plugin.sh",
"patchSetId": 19
},
"lineNbr": 43,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "6899cbb2_a50d22d9",
"range": {
"startLine": 43,
"startChar": 40,
"endLine": 43,
"endChar": 64
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9d0d1c32_099e3df7",
"filename": "devstack/plugin.sh",
"patchSetId": 19
},
"lineNbr": 65,
"author": {
"id": 16643
},
"writtenOn": "2023-05-19T00:52:55Z",
"side": 1,
"message": "same comment here as [1], the SSH user must be configurable.. \n\n[1] https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747/19/devstack/lib/cephadm#661",
"range": {
"startLine": 65,
"startChar": 32,
"endLine": 65,
"endChar": 37
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "47693a89_e4c3c2a9",
"filename": "devstack/plugin.sh",
"patchSetId": 19
},
"lineNbr": 65,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "9d0d1c32_099e3df7",
"range": {
"startLine": 65,
"startChar": 32,
"endLine": 65,
"endChar": 37
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2b29b263_43bc1725",
"filename": "devstack/plugin.sh",
"patchSetId": 19
},
"lineNbr": 65,
"author": {
"id": 32594
},
"writtenOn": "2023-05-19T19:58:59Z",
"side": 1,
"message": "Done",
"parentUuid": "9d0d1c32_099e3df7",
"range": {
"startLine": 65,
"startChar": 32,
"endLine": 65,
"endChar": 37
},
"revId": "bb523234a4fcbd4ee02a8427b28bc176d32a3efc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink