openstack
/
devstack-plugin-ceph
Code Issues Proposed changes
devstack-plugin-ceph/ba4bd594fd6b1b2360253eb5a8e...

369 lines
12 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "da6ed579_48ae8486",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 9,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:44:51Z",
"side": 1,
"message": "s/configure/configures/",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_e89c185f",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 16,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:44:51Z",
"side": 1,
"message": "I guess you were going for the \u0027ellipsis\u0027. It\u0027s constructed out of three dots and not four. And I don\u0027t get why you use it here and below?\nhttps://en.wikipedia.org/wiki/Ellipsis\n\nAm I missing something?",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_41fdff38",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 16,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T10:40:26Z",
"side": 1,
"message": "Thanks, i can agree to 3 dots.\nA commit msg is not a\nacademic paper to be so strict on the punctuations, i like\nto put it in my style, without worrying about the english \nlanguage specifics, as long as the point is conveyed, it \nshould be ok",
"parentUuid": "da6ed579_e89c185f",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_68eee8b5",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 18,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:44:51Z",
"side": 1,
"message": "s/Checking/Checked/\n\nand s/erroring/errored/",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_68d7c8ed",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 19,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:44:51Z",
"side": 1,
"message": "s/set/sets/\n\ns/Using/Used/",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_8826bccc",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 27,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:49:53Z",
"side": 1,
"message": "Please remove this line. You\u0027re the author as well. ;)",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_017aa7f1",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 27,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T10:40:26Z",
"side": 1,
"message": "Author was Seb, and hence i had put myself as co-author\nNot sure how that got changed, will fix it in next patchset",
"parentUuid": "da6ed579_8826bccc",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_178c2934",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 220,
"author": {
"id": 6984
},
"writtenOn": "2016-01-13T11:07:49Z",
"side": 1,
"message": "we need to check if rgw is enabled prior to attempt to kill it",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_f3775600",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 357,
"author": {
"id": 6984
},
"writtenOn": "2016-01-12T16:39:06Z",
"side": 1,
"message": "typo?",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_4983f456",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 357,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T04:29:41Z",
"side": 1,
"message": "No. If you see the diff of patchset 3 and 5, you can see that i moved the rgw+swift check to plugin.sh, so all that remains here is the call to configure_ceph_rgw function (since we moved the configuration of rgw to a diff function)\n\nWhy do you see it as a typo ?",
"parentUuid": "da6ed579_f3775600",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_643b7f9d",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 357,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T05:10:20Z",
"side": 1,
"message": "I should put the call to configure_ceph_rgw inside ENABLE_CEPH_RGW check tho\u0027. Will do in next patchset",
"parentUuid": "da6ed579_4983f456",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_b45a0029",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 432,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:11:36Z",
"side": 1,
"message": "A comment on why the service needs to be started in a configure.* function would be helpful.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_1708a990",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 583,
"author": {
"id": 6984
},
"writtenOn": "2016-01-13T11:07:49Z",
"side": 1,
"message": "we need to check if rgw is enabled prior to attempt to kill it",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_144f4cbe",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 616,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:28:43Z",
"side": 1,
"message": "Install \u0027radosgw\u0027 only if $ENABLE_CEPH_RGW \u003d True?",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_5c72c64a",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 616,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T10:49:33Z",
"side": 1,
"message": "Should be ok to install rgw but not run it, which happens\nonly when the env var is true.\n@Seb, what do you think ?",
"parentUuid": "da6ed579_144f4cbe",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_f75e35e8",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 616,
"author": {
"id": 6984
},
"writtenOn": "2016-01-13T11:07:49Z",
"side": 1,
"message": "It\u0027s harmless to have ceph-rgw installed but if it\u0027s not need we should not install it. So I\u0027m for a check if rgw is enabled.",
"parentUuid": "da6ed579_5c72c64a",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_1463ccdd",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 651,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:11:36Z",
"side": 1,
"message": "Execute only if $ENABLE_CEPH_RGW is True?",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_fc4dba72",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 651,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T10:46:44Z",
"side": 1,
"message": "ideally yes, but if radosgw is not running it would\nfail and thus the dev/null redirection, and thus is\nharmless and keep code leaner.\n\n@Seb, what do you think ?",
"parentUuid": "da6ed579_1463ccdd",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_940fbce0",
"filename": "devstack/override-defaults",
"patchSetId": 5
},
"lineNbr": 10,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:28:43Z",
"side": 1,
"message": "\"it\u0027s\" and not \"its\" is the shortened form of \"it is\".\n\nThe use of \u0027!\u0027 is weird. Why do you need a \u0027!\u0027 ?\n\nThe use of comma does not seem necessary.\n\nYou can simplify and reword the sentence.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_fc37faad",
"filename": "devstack/override-defaults",
"patchSetId": 5
},
"lineNbr": 10,
"author": {
"id": 10796
},
"writtenOn": "2016-01-13T10:46:44Z",
"side": 1,
"message": "Thanks, but in my style of english, i deem \u0027,\u0027 and \u0027!\u0027 necessary, not that I claim that my english is better, in fact it isnt :)\n\nAlso thats the best I can come up with, if you have a better way of re-wording and simplication, pls propose.",
"parentUuid": "da6ed579_940fbce0",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_749fa850",
"filename": "devstack/plugin.sh",
"patchSetId": 5
},
"lineNbr": 10,
"author": {
"id": 8056
},
"writtenOn": "2016-01-13T09:28:43Z",
"side": 1,
"message": "s/can not/cannot/",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink