55 lines
2.0 KiB
Plaintext
55 lines
2.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b976f754_1c80ca65",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 25
|
|
},
|
|
"lineNbr": 136,
|
|
"author": {
|
|
"id": 4393
|
|
},
|
|
"writtenOn": "2023-05-23T14:19:03Z",
|
|
"side": 1,
|
|
"message": "Why are you doing this? I think it\u0027d be better to leave it the way it is - have `CEPHADM` be the actual path to the tool and call it with `sudo` when appropriate (even if it\u0027s always).",
|
|
"revId": "94b582261cc795407188a0479439f36715210691",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ab39a40c_0d25f0bf",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 25
|
|
},
|
|
"lineNbr": 510,
|
|
"author": {
|
|
"id": 4393
|
|
},
|
|
"writtenOn": "2023-05-23T14:19:03Z",
|
|
"side": 1,
|
|
"message": "Running cat as sudo will not allow it to write to `$CEPH_CONF_DIR` because the file is actually opened by the shell. You want something like:\n```\ncat \u003c\u003cEOF | sudo tee $CEPH_CONF_DIR/$CEPH_CLUSTER_IS_READY.txt\n...\n```\nHowever since you only seem to care that it\u0027s created, you might as well just:\n```\nsudo touch $CEPH_CONF_DIR/$CEPH_CLUSTER_IS_READY.txt\n```",
|
|
"revId": "94b582261cc795407188a0479439f36715210691",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "72f57bfb_0c379175",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 25
|
|
},
|
|
"lineNbr": 515,
|
|
"author": {
|
|
"id": 4393
|
|
},
|
|
"writtenOn": "2023-05-23T14:19:03Z",
|
|
"side": 1,
|
|
"message": "Where is this called from?\n\nI assume it\u0027s going to be from the subnode to the master one? I\u0027m not sure this polling over ssh is really the best way to do it, but I\u0027d have to ask.",
|
|
"revId": "94b582261cc795407188a0479439f36715210691",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |