devstack-plugin-ceph/0f95a9553134a6debe2c64e2f32...

57 lines
1.8 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "5c4844f4_3e8a1936",
"filename": "devstack/lib/cephadm",
"patchSetId": 5
},
"lineNbr": 195,
"author": {
"id": 4523
},
"writtenOn": "2022-01-27T15:33:57Z",
"side": 1,
"message": "Sorry, this still races between line 195 and 197 if someone else is manipulating loopback devices -- you want something more like\n DEV\u003d`sudo losetup -f --show /var/lib/ceph-osd.img\"\n sudo pvcreate $DEV\n\netc",
"revId": "0f95a9553134a6debe2c64e2f32681393cf4cff7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a151ccfc_7b376a9f",
"filename": "devstack/lib/cephadm",
"patchSetId": 5
},
"lineNbr": 195,
"author": {
"id": 6413
},
"writtenOn": "2022-01-27T15:40:41Z",
"side": 1,
"message": "Like this?\n\n osd_dev\u003d$(sudo losetup -f --show /var/lib/ceph-osd.img)\n sudo pvcreate $osd_dev\n sudo vgcreate ceph_vg $osd_dev\n sudo lvcreate -n ceph_lv_data -l +100%FREE ceph_vg\n DEVICES+\u003d(\"ceph_lv_data\")",
"parentUuid": "5c4844f4_3e8a1936",
"revId": "0f95a9553134a6debe2c64e2f32681393cf4cff7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6b2a2bd6_dd89a359",
"filename": "devstack/lib/cephadm",
"patchSetId": 5
},
"lineNbr": 195,
"author": {
"id": 4523
},
"writtenOn": "2022-01-27T16:47:11Z",
"side": 1,
"message": "Yes, looks great.",
"parentUuid": "a151ccfc_7b376a9f",
"revId": "0f95a9553134a6debe2c64e2f32681393cf4cff7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}