devstack-plugin-ceph/ae18d31b8f27204340e5531e12f...

139 lines
3.6 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "fb762e12_d3423f3d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 25402
},
"writtenOn": "2022-02-16T15:58:13Z",
"side": 1,
"message": "Still WIP",
"revId": "ae18d31b8f27204340e5531e12f094ae33acaef3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7a09a996_df65cd8d",
"filename": "devstack/lib/cephadm",
"patchSetId": 12
},
"lineNbr": 304,
"author": {
"id": 16643
},
"writtenOn": "2022-02-23T17:19:47Z",
"side": 1,
"message": "check if this is necessary, the line below is supposed to create mds daemon/s as well..",
"range": {
"startLine": 302,
"startChar": 0,
"endLine": 304,
"endChar": 31
},
"revId": "ae18d31b8f27204340e5531e12f094ae33acaef3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ce99858f_682d9166",
"filename": "devstack/lib/cephadm",
"patchSetId": 12
},
"lineNbr": 304,
"author": {
"id": 25402
},
"writtenOn": "2022-02-24T08:18:03Z",
"side": 1,
"message": "+1, when `ceph fs volume create ` is called, 2 mds daemons are created. We can problably remove that line and save 1 command.",
"parentUuid": "7a09a996_df65cd8d",
"range": {
"startLine": 302,
"startChar": 0,
"endLine": 304,
"endChar": 31
},
"revId": "ae18d31b8f27204340e5531e12f094ae33acaef3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "59ee1c0c_d593a595",
"filename": "devstack/lib/cephadm",
"patchSetId": 12
},
"lineNbr": 304,
"author": {
"id": 25402
},
"writtenOn": "2022-02-24T08:54:36Z",
"side": 1,
"message": "Done",
"parentUuid": "ce99858f_682d9166",
"range": {
"startLine": 302,
"startChar": 0,
"endLine": 304,
"endChar": 31
},
"revId": "ae18d31b8f27204340e5531e12f094ae33acaef3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4098bfde_86a7cacc",
"filename": "devstack/lib/cephadm",
"patchSetId": 12
},
"lineNbr": 307,
"author": {
"id": 16643
},
"writtenOn": "2022-02-23T17:21:03Z",
"side": 1,
"message": "this doesn\u0027t seem to need \"--placement\": https://docs.ceph.com/en/latest/cephfs/fs-volumes/#fs-volumes",
"range": {
"startLine": 307,
"startChar": 8,
"endLine": 307,
"endChar": 31
},
"revId": "ae18d31b8f27204340e5531e12f094ae33acaef3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c7d31f1a_d7624e68",
"filename": "devstack/lib/cephadm",
"patchSetId": 12
},
"lineNbr": 307,
"author": {
"id": 25402
},
"writtenOn": "2022-02-24T08:57:23Z",
"side": 1,
"message": "Done",
"parentUuid": "4098bfde_86a7cacc",
"range": {
"startLine": 307,
"startChar": 8,
"endLine": 307,
"endChar": 31
},
"revId": "ae18d31b8f27204340e5531e12f094ae33acaef3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}