openstack/devstack
Code Issues Proposed changes

add big warning for extras.d usage

Browse Source 
This adds a warning for extras.d usage. This will give us something to
keep an eye on in logstash to build up the list of projects that will
break at Mitaka-1.

This also makes the deprecated handling done through a function, which
will hopefully make it more consistent in the future.

Change-Id: Icd393bc3e7095fe58be0fd13ef74fece3aa5c5f1
This commit is contained in:
Sean Dague 2015-10-07 08:46:13 -04:00
parent 1e7be9f9ea
commit 1de9e330de
1 changed files with 16 additions and 0 deletions

16
functions-common

@ -179,6 +179,12 @@ function die_if_not_set {
$xtrace $xtrace
} }
function deprecated {
local text=$1
DEPRECATED_TEXT+="\n$text"
echo "WARNING: $text"
}
# Prints line number and "message" in error format # Prints line number and "message" in error format
# err $LINENO "message" # err $LINENO "message"
function err { function err {
@ -1728,6 +1734,16 @@ function run_phase {
if [[ -d $TOP_DIR/extras.d ]]; then if [[ -d $TOP_DIR/extras.d ]]; then
for i in $TOP_DIR/extras.d/*.sh; do for i in $TOP_DIR/extras.d/*.sh; do
[[ -r $i ]] && source $i $mode $phase [[ -r $i ]] && source $i $mode $phase
# NOTE(sdague): generate a big warning about using
# extras.d in an unsupported way which will let us track
# unsupported usage in the gate.
local exceptions="50-ironic.sh 60-ceph.sh 80-tempest.sh"
local extra=$(basename $i)
if [[ ! ( $exceptions =~ "$extra" ) ]]; then
deprecated "extras.d support is being removed in Mitaka-1"
deprecated "jobs for project $extra will break after that point"
deprecated "please move project to a supported devstack plugin model"
fi
done done
fi fi
# the source phase corresponds to settings loading in plugins # the source phase corresponds to settings loading in plugins