openstack
/
devstack
Code Issues Proposed changes

Update patch set 29 

Patch Set 29: Code-Review+2

(4 comments)

Patch-set: 29
Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, c09e56a7529822fb85919d4444a8d08caadbb5dc
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
This commit is contained in:
Gerrit User 4146 2024-05-13 15:22:16 +00:00 committed by Gerrit Code Review
parent aaa5a89fce
commit 59850e84e0
1 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
f45f4d121eb7b6fd744e9045b518ee9b12e59064
View File

@ -87,6 +87,41 @@
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "519d086f_3db714eb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 29
},
"lineNbr": 0,
"author": {
"id": 4146
},
"writtenOn": "2024-05-13T15:22:16Z",
"side": 1,
"message": "Part of the motivation behind this is it allows us to cache keystone tokens in the server/osc shell as well as avoid repeated python startup costs with starting a new osc each run. This in theory will cut minutes off of every devstack job that uses it saving time and resources.",
"parentUuid": "f5c57402_e6ab134f",
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4f094445_a9262ff2",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 29
},
"lineNbr": 0,
"author": {
"id": 4146
},
"writtenOn": "2024-05-13T15:22:16Z",
"side": 1,
"message": "I\u0027m in favor of this. It appears to be disabled by default and there are indications it will save us resources. We have to consider that the status quo isn\u0027t perfect either (and is extremely user unfriendly with how slow it can be). This improves the user experience and we can improve it along the way without having it be perfect upfront.",
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -122,6 +157,23 @@
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "247428de_f52645d8",
"filename": "files/openstack-cli-server/openstack",
"patchSetId": 29
},
"lineNbr": 102,
"author": {
"id": 4146
},
"writtenOn": "2024-05-13T15:22:16Z",
"side": 1,
"message": "Is there some reason the osc shell in the server can\u0027t report this error and we have to catch it early here? That might be worth a comment if so.",
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -244,6 +296,23 @@
"parentUuid": "85bda257_ee5a2813",
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b73f9311_97ef123e",
"filename": "unstack.sh",
"patchSetId": 29
},
"lineNbr": 102,
"author": {
"id": 4146
},
"writtenOn": "2024-05-13T15:22:16Z",
"side": 1,
"message": "Nit: Should this be the very last service we stop so that any other services that need to use osc during the stop can take advantage of this longer lived faster service for API interaction?",
"revId": "f45f4d121eb7b6fd744e9045b518ee9b12e59064",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}