openstack/devstack
Code Issues Proposed changes

Fix neutron empty string check

Browse Source 
The variable should be in quotes for the check to work

Testing the behavior in bash:
current behavior:
$ config_file=""
$ if [ -n ${config_file} ]; then echo a; fi
a

$ config_file="abc"
$ if [ -n ${config_file} ]; then echo a; fi
a

behavior with quotes:
$ config_file=""
$ if [ -n "$config_file" ]; then echo a; fi

$ config_file="abc"
$ if [ -n "$config_file" ]; then echo a; fi
a

Change-Id: Iba956d9d4f43b925848174a632aabe58999be74b
This commit is contained in:
Jaromir Wysoglad 2024-03-27 11:36:26 +01:00
parent f4f09416ca
commit c336b87342
1 changed files with 1 additions and 1 deletions

2
lib/neutron_plugins/ovn_agent

@ -558,7 +558,7 @@ function configure_ovn {
sample_file=$NEUTRON_DIR/etc/neutron_ovn_metadata_agent.ini.sample sample_file=$NEUTRON_DIR/etc/neutron_ovn_metadata_agent.ini.sample
config_file=$OVN_META_CONF config_file=$OVN_META_CONF
fi fi
if [ -n ${config_file} ]; then if [ -n "$config_file" ]; then
sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR
mkdir -p $NEUTRON_DIR/etc/neutron/plugins/ml2 mkdir -p $NEUTRON_DIR/etc/neutron/plugins/ml2