Update patch set 5

Patch Set 5: Code-Review-1

(2 comments)

Patch-set: 5
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 4d3a11c201a6801442a15e6da1ab1b194c5e7d49
Attention: {"person_ident":"Gerrit User 36898 \u003c36898@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
Gerrit User 13252 2024-05-13 09:09:35 +00:00 committed by Gerrit Code Review
parent 7dc19a68ea
commit d43e8d0002
1 changed files with 40 additions and 0 deletions

View File

@ -33,6 +33,46 @@
"message": "Nice",
"revId": "59f5acfc6ff8e37ef2d08bcaabeaab3335953229",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6f6fb0f6_1689ab4d",
"filename": "lib/horizon",
"patchSetId": 5
},
"lineNbr": 112,
"author": {
"id": 13252
},
"writtenOn": "2024-05-13T09:09:35Z",
"side": 1,
"message": "IMHO this extra option is not needed, if the c-bak service is there, we can tell horizon about it, or is there a scenario where this would be not wanted?",
"range": {
"startLine": 112,
"startChar": 35,
"endLine": 112,
"endChar": 75
},
"revId": "59f5acfc6ff8e37ef2d08bcaabeaab3335953229",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1b263ccb_7fbf39c2",
"filename": "releasenotes/notes/add-option-enable-backup-dashboard-71d95ad5f836a2e3.yaml",
"patchSetId": 5
},
"lineNbr": 5,
"author": {
"id": 13252
},
"writtenOn": "2024-05-13T09:09:35Z",
"side": 1,
"message": "Devstack doesn\u0027t do release notes. The one that is in place currently was created in error, see https://review.opendev.org/c/openstack/devstack/+/919485\n\nSo please drop this, the referenced bug report is good enough",
"revId": "59f5acfc6ff8e37ef2d08bcaabeaab3335953229",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}