openstack/devstack
Code Issues Proposed changes

Install bindep packages when installing lib from src

Browse Source 
Most libs maintain their own system packages in a local bindep.txt file.
We don't currently use those when installing packages from source, which
can result in broken package installs.

This adds a flag to always attempt to install bindep packages if the
bindep.txt file exists. If a file cannot be found, it will just emit a
warning and carry on.

Change-Id: Ia0570f837b8af1c3fee0a314b026a4a7ed27e6a9
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This commit is contained in:
Sean McGinnis 2020-07-28 08:51:41 -05:00
parent 32d5b1ea2f
commit dd3731c86a
No known key found for this signature in database
GPG Key ID: CE7EE4BFAF8D70C8
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
functions-common
View File

@ -1412,7 +1412,8 @@ function install_bindep {
local pkgs local pkgs
if [[ ! -f $file ]]; then if [[ ! -f $file ]]; then
die $LINENO "Can not find bindep file: $file" warn $LINENO "Can not find bindep file: $file"
return
fi fi
# converting here makes it much easier to work with passing # converting here makes it much easier to work with passing

2
lib/libraries
View File

@ -72,7 +72,7 @@ function _install_lib_from_source {
local name=$1 local name=$1
if use_library_from_git "$name"; then if use_library_from_git "$name"; then
git_clone_by_name "$name" git_clone_by_name "$name"
setup_dev_lib "$name" setup_dev_lib -bindep "$name"
fi fi
} }