openstack/devstack
Code Issues Proposed changes

Don't reinstall package just after installing.

Browse Source 
Boolean logic used in install_package was wrong:
on nominal flow packages were actually installed twice.
This should fix it.

Change-Id: Ia465414936b272d04523a11f83d6ded378fe1daf
Closes-Bug: #1518544
This commit is contained in:
Federico Ressi 2015-12-28 15:14:13 +01:00
parent 828936c6ac
commit ecc1f41d50
1 changed files with 3 additions and 1 deletions

4
functions-common

@ -1245,7 +1245,9 @@ function real_install_package {
# install_package package [package ...]
function install_package {
update_package_repo
real_install_package $@ || RETRY_UPDATE=True update_package_repo && real_install_package $@
if ! real_install_package "$@"; then
RETRY_UPDATE=True update_package_repo && real_install_package "$@"
fi
}
# Distro-agnostic function to tell if a package is installed