openstack/devstack
Code Issues Proposed changes

Ensure valid service names are passed to stack_install_service

Browse Source 
Currently, stack_install_service will accept any service name. This is
problematic because a project plugin can pass an invalid name without
noticing. This has been the case in ironic-inspector[0].

This commit ensures that stack_install_service will not silently fail
when passing an invalid service name.

[0] https://review.openstack.org/#/c/424680/

Change-Id: I1a8105bdbaf4aecb630df08da416808bf7180824
Closes-Bug: #1659042
This commit is contained in:
Mathieu Mitchell 2017-01-24 11:32:24 -05:00 committed by Mathieu Mitchell
parent 07d612e460
commit fa55cb5f97
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/stack
View File

@ -33,5 +33,8 @@ function stack_install_service {
if [[ ${USE_VENV} = True && -n ${PROJECT_VENV[$service]:-} ]]; then if [[ ${USE_VENV} = True && -n ${PROJECT_VENV[$service]:-} ]]; then
unset PIP_VIRTUAL_ENV unset PIP_VIRTUAL_ENV
fi fi
else
echo "No function declared with name 'install_${service}'."
exit 1
fi fi
} }