8268 Commits

Author SHA1 Message Date
John L. Villalovos
c6e6939e89 Fix error in 'ip netns' parsing
Sometimes when doing worlddump would see a command line like this:
 sudo ip netns exec (id: ip addr

This would cause an error to be seen in console.log:
  2017-02-07 00:03:03.659570 | /bin/sh: 1: Syntax error: "(" unexpected

This is caused by there sometimes being extra data returned from the
'ip netns' command [1]. For example it might look like:
    qrouter-0805fd7d-c493-4fa6-82ca-1c6c9b23cd9e (id: 1)
    qdhcp-bb2cc6ae-2ae8-474f-adda-a94059b872b5 (id: 0)

[1] https://lwn.net/Articles/629715/

Change-Id: Icece442023125ef55696b8d92a975d37e358b1b4
Closes-Bug: 1653969
2017-02-14 09:29:54 -08:00
Jordan Pittier
4370925181 TLS proxy: disable HTTP KeepAlive
There's a race condition when a client makes a request "at the same
time" the HTTP connection is being closed by Apache because the
`KeepAliveTimeout` is expired.

This is explained in detail and can be reproduce using
https://github.com/mikem23/keepalive-race or
https://github.com/JordanP/openstack-snippets/blob/master/keepalive-race/keep-alive-race.py

Just disable KeepAlive to fix the
('Connection aborted.', BadStatusLine("''",)) error we are seeing.

Change-Id: I46e9f70ee740ec7996c98d386d5289c1491e9436
2017-02-14 16:59:07 +01:00
Jordan Pittier
bc3d01c8ec Revert "tls proxy: immediately close a connection to the backend"
This reverts commit e0a37cf21e43fbb4ba3f9f8fa5321a0a0e1bedf1.

This didn't help fixing bug #1630664. Issue seems to be between
client<--->Apache2, not between Apache2<--->eventlet

Change-Id: I092c1bbf0c5848b50fc9e491d1e9211451208a89
2017-02-14 15:46:03 +00:00
Matthew Treinish
6fc332d852
Switch devstack to use qcow cirros img
This commit switches devstack to use the published qcow2 cirros image
instead of the AMI version. Using AMI was mostly a historical artifact
dating pretty far back, but in the real world no one really uses AMI
images with openstack clouds. This change reflects that and also
enables tempest ro remove its deprecated config options for using AMI
as a fallback on misconfiguration (which was just there to support
devstack's defaults)

Change-Id: Id65ebae73b28da7185cb349b714b659af51ef77f
2017-02-14 08:41:25 -05:00
Matt Riedemann
ff10ac318c Remove distro support based on new libvirt minimum
Nova is going to increase the minimum required libvirt
in Pike to 1.2.9 in change:

I9a972e3fde2e4e552f6fc98350820c07873c3de3

Based on the libvirt distro support matrix wiki [1] that
drops support for Ubuntu Trusty and Debian 7.0/Wheezy.

Trusty has libvirt 1.2.2 and Wheezy has 0.9.12 (the Wheezy
support should have been removed long ago apparently). The
7.0 removed here is for Wheezy also based on commit
b2ef890db3d78b24f9da2f4dd80502165c669ad0.

This does not undo the check for "trusty" with the
EBTABLES_RACE_FIX in lib/nova_plugins/function-libvirt
since you can still force devstack to run on Trusty if
you specify the FORCE=yes variable.

Note that RHEL 7.1 has libvirt 1.2.8 so it won't technically
work with devstack and nova + pike + libvirt, but with the
way os_RELEASE is calculated the minor version is dropped
for RHEL distros so we just get "rhel7".

Also note that this doesn't attempt to continue supporting
Trusty or Wheezy if nova is not configured to use libvirt,
simply in order to start moving forward on devstack distro
support in general and to keep some sanity and closeness
to what we test with in the CI system.

While we're in here, we also drop Fedora 23 and add
Ubuntu Zesty.

[1] https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix

Depends-On: I9a972e3fde2e4e552f6fc98350820c07873c3de3
Depends-On: If69f99bd789e646b0261e27a8a061efde32436f7

Change-Id: I6617283afd798af37e64913b7865cea3c8a62aba
2017-02-13 16:31:39 -05:00
Sean Dague
bfff93e156 remove keystone internal uri
There is really no reason to have an internal uri referenced for
keystone in devstack.

Change-Id: If0588a0ab512d94451992e7131dd3c8a33c5797c
2017-02-13 16:18:08 -05:00
Sean Dague
11eb2017ef simplify endpoints used in devstack
The proliferation of internal/admin endpoints is mostly legacy and
based on some specific deployment patterns. These are not used by
everyone, and for the devstack case aren't really that useful. We
should simplify our service catalog down to the minimum we need for
development.

Change-Id: Ided7a65c81b3a0b56f0184847fc82e17c29a771e
2017-02-13 16:16:59 -05:00
Jenkins
6bd3561e9d Merge "Generate deprecation warning for postgresql" 2017-02-13 19:57:46 +00:00
Attila Fazekas
9ef346f59d Using sudo in the Quick start section
Adding sudo to the example commands in the quick start section.

Also adding '-' as su argument in order to use
the stack user's env (home).

Change-Id: I23ab38104d05c3f4c8d48b55e66cf19dc4e4f90d
2017-02-13 15:14:41 +01:00
Sean Dague
ee37d20f80 pass role by name not id
Change-Id: Ie67758bed3563c9a46a5180eaa9c8d47721fffd8
2017-02-13 14:06:03 +00:00
Andrea Frittoli (andreaf)
9f2dcd3331 Use the latest 0.3.5 version of CirrOS
This new version of CirrOS is built on top of 0.3 branch, so wrt
version 0.3.4 it includes only two commits:

- Cherry-pick of the fix for https://launchpad.net/bugs/1564948
- One extra fix to make the above working on 0.3

Cherry-picked commit is http://bazaar.launchpad.net/~cirros-dev/cirros/trunk/revision/366

A Tempest test for hard reboot in some cases hits the case where
host key are empty. This triggers bugs/1564948, i.e. the ssh
daemon does not start at all, and the Tempest test fails with
"connection refused", which is misleading.

The new version of CirrOS solves this problem as it ensure host
keys are generated if missing, and the sshd deamon started.

I tested the scenario of missing host keys in Iea74c63925be17a1df894c1a2c23f5ba2793e0c6
using a private build of what then became 0.3.5.

Change-Id: I5c154ec25555e768954538fc22b4f5d5975b2deb
2017-02-12 22:14:15 +00:00
Jordan Pittier
e0a37cf21e tls proxy: immediately close a connection to the backend
Force mod_proxy to immediately close a connection to the backend
after being used, and thus, disable its persistent connection and
pool for that backend.

Let's see if that helps fixing bug #1630664 (the
Connection aborted/ BadStatusLine thing).

We already have an ER query (in queries/1630664.yaml) that should show
whether this is effective.

Change-Id: I03b09f7df5c6e134ec4091a2f8dfe8ef614d1951
2017-02-10 15:04:52 +01:00
Ihar Hrachyshka
952ecb6fec Don't set external_network_bridge by default
Since the empty value is the default for the option, and when explcitly
set in config file, it triggers a deprecation warning for the option,
avoid setting it unless we actually need to override the new default
value.

Change-Id: If423114d7a52da29b97d1fb473a955d9d69a1a3e
2017-02-10 06:39:04 +00:00
Ihar Hrachyshka
47bcf4fbcb Removed neutron_plugin_configure_debug_command functions
Those are not called by devstack anymore. This cleanup also gets rid of
code that attempts to set external_network_bridge to an empty value,
which triggers a deprecation warning for the option since it's going to
be removed in a next Neutron release.

Change-Id: I5adcbab877b4e8742522de81b1a85acfc33160d7
2017-02-10 06:39:04 +00:00
Sean Dague
999dd7e989 only apply ebtables race fix on trusty
Change-Id: Ifc83e7301d9d921ce9ceed349f116584ce03842b
2017-02-09 17:56:40 -05:00
Jenkins
a6ecdd1167 Merge "lib/tempest: remove an unused network option" 2017-02-09 10:32:54 +00:00
Jenkins
0dccb52b75 Merge "Remove OS_NO_CACHE from openrc" 2017-02-09 10:08:25 +00:00
OpenStack Proposal Bot
26e5a00957 Updated from generate-devstack-plugins-list
Change-Id: I4cf11a25b1d107cc5ab9664cae47a5a13f7a2450
2017-02-08 14:19:00 +00:00
Sean Dague
d9aaae95f2 Generate deprecation warning for postgresql
Change-Id: I599e6d84b70bb6a7718ae48dd0cfc91796af189e
2017-02-08 07:49:26 -05:00
Roman Podoliaka
88b84094ec mysql: set default sql_mode to TRADITIONAL
We currently use a more permisive STRICT_ALL_TABLES mode, but that's
not what modern MySQL versions default to (i.e. TRADITIONAL):

https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-changes

(non-Devstack deployments will most likely use TRADITIONAL as well)

Due to the fact that we default to TRADITIONAL in oslo.db, this
produces annoying warnings on MySQL 5.7 versions we use in the gate:

    Warning: (3090, u"Changing sql mode 'NO_AUTO_CREATE_USER' is
              deprecated. It will be removed in a future release.")

https://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/options.py#n49

Unlike STRICT_ALL_TABLES, TRADITIONAL mode includes NO_AUTO_CREATE_USER,
and MySQL emits this warning on switching it on:

https://dev.mysql.com/worklog/task/?id=8326

So we have two options here:

1) make oslo.db default to STRICT_ALL_TABLES
2) make Devstack default to TRADITIONAL

The latter seems to be more appropriate as:

1) it's what modern MySQL versions default to
2) it's what people are actually using, if they do not override the
   oslo.db default
3) it's more strict

Closes-Bug: #1652452

Change-Id: Ie6d823c9f8465ac9f2ce4825929d1a50438fab45
2017-02-07 18:01:25 +02:00
Hirofumi Ichihara
40aae6adbf Down PUBLIC_BRIDGE before trying to delete it
When cleanup devstack with linuxbridge, PUBLIC_BRIDGE should be
DOWN before trying to delete it.

Change-Id: I2d205cbe4d92a03ee5c376a23282d9880dd9a1df
Closes-Bug: #1662543
2017-02-08 00:12:04 +09:00
Jordan Pittier
fd40677297 lib/tempest: remove an unused network option
Tempest doesn't support the `api_version` config option for networking
anymore. I can't track which Tempest patch removed it, but it's been more
than 2 years.

Change-Id: I4012f470e8c317803203b6fa1e265600dbc49b3d
2017-02-07 14:43:32 +01:00
Jenkins
7eef546f8a Merge "Cut back on the number of workers ran for neutron" 2017-02-07 04:04:33 +00:00
John L. Villalovos
09949e0dc6 worlddump: Use __future__ print_function
Commit e7361775c112e32ea517eddc344641897d273d25 changed the code to
use Python 3 style print function, but when doing 'print()' in Python
2.7 it would print '()':
    >>> print()
    ()

Import the __future__ print function so that a blank line will be
printed as expected. This will now work the same in Python 2 & 3.

Change-Id: I61742e107278f2327c18c9ab0de52d1914f16c97
2017-02-06 13:55:52 -08:00
Jordan Pittier
1868232485 lib/tempest: Liberty EOL: remove the volume_services feature flag
Now that Liberty is EOLed, the feature flag is not needed anymore.

Change-Id: Ib82cb21edbda383d17f8cf69fedc884f2357fead
Depends-On: I7073106988a79aad19c6b95bb050d2eaf00c36c0
2017-02-06 09:43:08 +00:00
Armando Migliaccio
06f2ea2b96 Cut back on the number of workers ran for neutron
The dedicated RPC worker is overkill in single or multinode
devstack deployments. Also metadata API workers was left
default, which meant they were as many as the CPU cores.

Related-bug: 1656386

Change-Id: Ibbf7787dfa48e13a51f961f3e0ee2b8f49964759
2017-02-05 08:04:49 -08:00
Jenkins
bab8516a85 Merge "Enable VNC console in tempest.conf" 2017-02-03 16:24:32 +00:00
Jenkins
0ab0e50011 Merge "Create private IPv6 subnet specifying mode flags" 2017-02-03 16:24:25 +00:00
Jenkins
f0b9e841c4 Merge "Change the way to get conntrack-tools version" 2017-02-03 16:23:14 +00:00
Matthew Treinish
6d79ebcae1
Add top memory consuming process to dstat output
Right now we under pressure because of increasing memory consumption in
dsvm jobs. So it'll be good to see which process is eating the most ram
at a given time. It may not end up being useful, but it doesn't hurt to
at least display just in case.

Change-Id: I096bf4b425db51358240335e41f6238d1ec1bb40
2017-02-02 10:52:53 -05:00
OpenStack Proposal Bot
debc695ddf Updated from generate-devstack-plugins-list
Change-Id: Ia858ddf2e688903af2c76d532ddf7780bd591ef9
2017-02-01 07:27:18 +00:00
PranaliD
705b3785ca Corrected router gateway set command
While configuring the external network as the default
router gateway for IPV6 in lib/neutron_plugins/services/l3,
"router" keyword is missing in the command.

Corrected the command.

Change-Id: I055bea5137a841f709d4865ec9a43d6b53f8f4c9
Closes-Bug: 1660712
2017-02-01 11:33:44 +05:30
Matt Riedemann
ac5fdb4c40 nova: call map_cell0 much earlier in the setup
The map_cell0 command creates a cell mapping record in the
nova_api database, and the nova-manage db sync command
will migrate the db schema for the nova_cell0 database. This
patch takes advantage of that by moving the map_cell0 call
much earlier in the setup process so we get the nova_cell0
db schema migrated at the same time as the main nova db.

This also removes the || true condition around map_cell0
since it's idempotent now due to fix:

aa7b6ebbb254f00fcb548832941ca9dbd3996d9f

Change-Id: Ice4fbb1771270c618b2acbc933d4fbfb6805df81
2017-01-31 15:20:18 -05:00
Matt Riedemann
e1644ac1d8 Remove OS_NO_CACHE from openrc
Nothing uses this variable either in devstack or libraries,
so it's dead code (at least on master), and we can remove it.

Change-Id: I5975c476ae5b26402c209d6e5746e7a5a5a91507
2017-01-31 11:59:09 -05:00
Jenkins
e6f8dbb55f Merge "Don't run swap_volume tests in Tempest if cells v1 is enabled" 2017-01-31 13:16:08 +00:00
Jenkins
bd14f7f23e Merge "unify logging setup on all services" 2017-01-31 06:26:17 +00:00
Matt Riedemann
e9a9fbef8f Don't run swap_volume tests in Tempest if cells v1 is enabled
Cells v1 apparently doesn't support the swap volume API which
was recently enabled for testing in change:

92575baa6b010ec09fea3e715030da8be61c0c64

Rather than revert that change, we should just handle the cells
v1 case and not enable that test in that environment.

Change-Id: I80f52e8299641098d90d3c374a80770fc45b8122
Closes-Bug: #1660511
2017-01-30 22:22:43 -05:00
Jenkins
a935193bae Merge "tempest: configure compute-feature-enabled.swap_volume if libvirt" 2017-01-31 00:42:28 +00:00
Mehdi Abaakouk
5c6aa56e11 Don't assume nova-manage is present
tools/discover_hosts.sh is run by devstack-gate, and breaks all dsvm job
that doesn't use nova.

nova-manage is perhaps not installed if nova services are not enabled.

This change checks the presence of nova-.

Change-Id: Ic555d241f98d0fa027897c69a7115d1be88f6c96
2017-01-26 16:21:54 +01:00
Matt Riedemann
5713497aa5 Add discover_hosts.sh script
This adds a simple script to run the
'nova-manage cell_v2 discover_hosts'
command which will be used by
devstack-gate to discover the compute
hosts after devstack is fully setup.

This allows us to manage the branches
where this can run from devstack rather
than require branch logic in devstack-gate.

Change-Id: Icc595d60de373471aa7ee8fb9f3a81fc12d80438
Depends-On: I4823737246a8e9cc4eaebf67ff6bdba8bf42ab29
2017-01-25 13:45:27 -08:00
Jenkins
adcf0c50cd Merge "remove obsolete s3 conf from nova.conf" 2017-01-23 23:37:02 +00:00
Jenkins
7a1e6f042f Merge "simplify colorized logging setup" 2017-01-23 23:35:19 +00:00
Michelle Mandel
10db2b8e65 Enable VNC console in tempest.conf
If the NoVNC service is enabled, enable vnc_console in tempest.conf.
This will allow tempest tests that interact with VNC to be executed.

Change-Id: Idb38a3b11e2f61f23adf1ec23c04ddccd72e7539
Depends-On: I09aed8de28f1ba2637382e870134ced38808df29
2017-01-23 10:39:01 +00:00
Jianghua Wang
465ee45986 XenAPI: enable root_helper_daemon for XenServer
The daemon mode of root helper for XenAPI has been implemented by
this change which has been merged to neutron:
https://review.openstack.org/#/c/390931/
It will help to import the performance. Let's enable this mode
by default in devstack.

Change-Id: I52246bef3e4434dfc49446535b122580bc475ac3
2017-01-23 07:46:56 +00:00
Jenkins
a1913db5d7 Merge "remove db setting when no nova service need it" 2017-01-20 20:48:56 +00:00
Sean Dague
fb1c7b51b5 remove obsolete s3 conf from nova.conf
Change-Id: If0b42c647382b739ee4f1d98ea0394ec7b171ebf
2017-01-20 19:01:14 +00:00
Sean Dague
9751be66fa unify logging setup on all services
This provides a single setup_logging function which builds consistent
colorization if the config supports it, otherwise builds the identity
strings that we need to actually keep track of requests.

Change-Id: Iffe30326a5b974ad141aed6288f61e0d6fd18ca9
2017-01-20 10:48:29 -05:00
Sean Dague
b6753cea8c simplify colorized logging setup
This makes setup_colorized_logging be a thing which takes a single
parameter and doesn't let projects do things differently. It also
changes the order of values from user / project to project / user to
represent the hierachy more clearly.

Change-Id: I8c0ba7da54be588e3e068734feb4f78ed7c5a14a
2017-01-20 10:48:20 -05:00
Jenkins
df09c43386 Merge "add install_devstack_tools" 2017-01-19 18:24:52 +00:00
Jenkins
e19c8c34c5 Merge "Remove baremetal tempest config setting from devstack" 2017-01-19 10:32:20 +00:00