349 Commits

Author SHA1 Message Date
Stephen Finucane
248d4bb8d2 Stop configuring '[DEFAULT] firewall_driver' for nova
This option has default to the 'NoopFirewallDriver' for some time and
will soon be removed. Stop configuring it entirely.

Change-Id: I4dbc0015cf26d7edf51d0d5fd978ccd3a1ad1b79
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2020-01-16 09:27:54 +00:00
Lenny Verkhovsky
d6a7b73fc8 Create OVS bridge even if OVS_BRIDGE_MAPPINGS is not empty
in complex cases when mapping is defined in local.conf OVS bridge
can be created automatically.

Change-Id: I2e5e1068e77291d1d199cd698cec4946480c7601
2019-12-18 08:09:11 +00:00
Brian Haley
da18895162 Fix brctl calls
Some distros no longer ship brctl, iproute2 should be used
in its place. The linuxbridge agent plugin script was still
using it, as was worlddump, which generates this warning on
a failure:

    Running devstack worlddump.py
    /bin/sh: 1: brctl: not found

Conditionalizing worlddump based on whether brctl is installed
to make this go away.

Change-Id: Iafbf4038bab08c261d45d117b12d4629ba32d65e
2019-11-06 09:55:47 +08:00
Jens Harbott
0c9a6cab91 Enable accept_ra before enabling forwarding
We need to enable accept_ra before we enable forwarding, otherwise
existing addresses and routes may get dropped until the next RA is
received, possibly causing connection errors in the meantime.

Change-Id: I1fdeede59547de896ed89222ecf121fd9e6b810d
2019-09-19 13:59:28 +00:00
Zuul
7bc5220493 Merge "DVR-Enable ARP Responder when DVR and L2pop is enabled" 2019-08-21 17:34:47 +00:00
Swaminathan Vasudevan
9bf7e26541 DVR-Enable ARP Responder when DVR and L2pop is enabled
This patch enables ARP Responder with DVR routers along with
l2pop in devstack.

Related-Bug: #1774459

Change-Id: I82f628c32f6e38c2419b6ffe90d9f9adf96777b1
2019-05-16 19:08:58 +00:00
Brian Haley
245445b1bd Use L3RouterPlugin alias
The 'router' alias for the L3RouterPlugin has been in
setup.cfg for a while, let's use it.

Change-Id: Ifa196bd33959f1425df9a34cdab4acf4c3b8071b
2019-03-21 11:40:17 -04:00
Zuul
357afa9715 Merge "Revert "Revert "remove external_network_bridge option""" 2019-03-13 21:00:11 +00:00
Zuul
e86a6aa924 Merge "Replace deprecated brctl with ip commands" 2019-03-12 22:22:05 +00:00
Nate Johnston
56946cfc5f Replace deprecated brctl with ip commands
The bridge-utils package has been deprecated for some time now [1] and
'brctl' does not exist on some more recent distros like Fedora 28.
Replace references to brctl with the proper ip commands.

Calls to "brctl show" are not being replaced with calls to "bridge link"
because the output format is very different and in testing some bridges
were not listed.  So the simpler method of consulting /sys/class/net is
used.

In worlddump.py we try running both because failures are handled
gracefully by _dump_cmd(), as well as "ip link show type bridge" for
additional info.

[1] https://lwn.net/Articles/703776/ for example

Change-Id: Ie4c8ad6ce4a09c38023c9e4ec7834c249403145f
Partial-Bug: #1801919
2019-03-01 14:36:38 -05:00
Hongbin Lu
55f172961a Revert "Revert "remove external_network_bridge option""
This reverts commit e3e9ea299601665a295e31a98e90dd9587165850.

Change-Id: I23e1b98bd2839b79226b55700ee404a8fda83f83
2019-02-27 14:57:22 +00:00
Adam Spiers
bbb6b0c240 Fix version comparison for SUSE Linux Enterprise 12
The version comparison introduced in
I5152f2585c3d4d18853988d6290039d6b1713b99 was broken, because it tried
to use bash's -lt operator for floating point comparison, but bash
only supports integer arithmetic.

So instead use devstack's vercmp() function.

Change-Id: I8aac71c5bb6c2e82479d62831ea0672ba6a9a534
2019-01-25 01:05:58 +00:00
Derek Higgins
e3e9ea2996 Revert "remove external_network_bridge option"
This reverts commit faaf96bfb15c5f4c45a72b149dc6fe1e1f907a71.

Ironic jobs were still using this option, it needs to be
switched to an alternative first.

Change-Id: I1683d7cfa81f5fe2497cc7045e87f8b20fed4968
2018-11-09 15:45:46 +00:00
Zuul
7c3df6b700 Merge "remove external_network_bridge option" 2018-11-07 00:35:02 +00:00
aojeagarcia
866efef17a Allow ipv6 ECMP in devstack
It turns out that a host can have multiple valid default gateways,
something that's not common in ipv4.

This patches add supports for multiple default gateways in ipv6
environments.

Closes-Bug: #1786259

Change-Id: I30bf655f7160dd19c427ee79acdf145671a3e520
Signed-off-by: aojeagarcia <aojeagarcia@suse.com>
2018-09-28 08:48:55 +00:00
Hongbin Lu
faaf96bfb1 remove external_network_bridge option
The external_network_bridge option is deprecated/legacy and being
removed from neutron (see I07474713206c218710544ad98c08caaa37dbf53a).
This patch removes the external_network_bridge option iniset from
devstack scripts.

Change-Id: I4d9641cc9bb83719c9af1edabb89a63c4c2b1d96
2018-09-26 14:49:07 +00:00
melissaml
5ed05394ff fix a typo
Change-Id: I3cc4633b125ef3c5be40dd444cad78a888f832e4
2018-09-20 10:47:16 +08:00
Matt Riedemann
e95f2a3664 Configure [neutron] in nova_cell*.conf
The nova-conductor service running in the cell
needs to be configured to talk to neutron for
things like deallocating networks during server
build failure. This changes the configure_neutron_nova
flows such that the top-level nova.conf is configured
as before, but we also configure each nova_cell*.conf
cell conductor config files to also be able to talk
to neutron.

Change-Id: Ic5e17298996b5fb085272425bb3b68583247aa34
Closes-Bug: #1777505
2018-06-18 16:20:39 -04:00
Jakub Libosvar
a99ab7002c neutron: Use openvswitch firewall driver by default
openvswitch firewall has been in Neutron tree since Newton and has gone
through lots of improvements since including simple upgrade path from
the iptables hybrid driver.

We have a tempest job running in Neutron tree with openvswitch firewall
that's been voting and stable for a while. For neutron_tempest_plugin,
we have had the openvswitch firewall in use since the beginning.

This patch proposes openvswitch firewall driver to become a default
driver for openvswitch agent deployments.

Change-Id: If26d0180e459210511f25f1faa83dd8ccea25ff4
2018-05-14 16:16:08 +02:00
Dirk Mueller
486057f339 Start OVS as root on Tumblweed to workaround bsc#1085971
There is currently a OVS 2.9.0 update in Tumbleweed that
fails to start as it is having a race with systemd on creating
the home directory. Workaround is to run it as root for now.

Change-Id: Ief610c6473834b02a1d644d8f50d11138a48e6e6
2018-04-11 21:31:53 +02:00
Tim Swanson
bb7d2f233b Allow public router external net to use a non-flat provider network.
Allow users to auto-create a neutron non-flat providernet public network
and use it for external router interfaces.  By default, keep the existing
flat network type behavior.

Change-Id: I64f71b0c9fcac97b9b84b7d30ee61659b2a690f1
2018-01-18 10:59:51 -05:00
Shachar Snapiri
fe4c3cfcf5 Modified the subnet-range parameter to be optional
The subnet-range parameter is only sent now if a valid value exists so
the command will not fail

Change-Id: I5296f5b59bc6d3d3db90a685a8678db9a156eece
Closes-Bug: #1718111
2018-01-08 12:27:19 +00:00
Jenkins
c2ae15a6dd Merge "Make subnet pool names unique" 2017-09-05 12:21:11 +00:00
Huan Xie
c779b00840 Remove XenServer specific ovs agent config
With XenServer we have two neutron-openvswitch-agent(q-agt, q-domua)
For the q-domua it is specific for XenServer, this patch is to move
the specific configurations to os-xenapi which we have devstack plugin
in that repo

Depends-On: Ic816404c84f6a8899d01a77cb67fbfb421653e6b

Change-Id: I8a31c81d9475387fe4ed7030b70b26098e588771
2017-03-21 20:56:58 -07:00
Ben Swartzlander
d15f222e2b Fix IPv6 provider networks
Add a missing --subnet-range argument when creating an ipv6 provider
network. Also changed SUBNET_V6_ID to IPV6_SUBNET_ID. And remove the
--ipv6-address-mode arg because it doesn't apply to subnets on routers.

Change-Id: I82796804a06e758e458606dc9eb400bcd08ad6e4
2017-03-11 01:50:01 +00:00
Jenkins
073c225257 Merge "Skips enabling kernel bridge firewall in container" 2017-03-03 16:20:20 +00:00
Denis Buliga
0bf75a471e Skips enabling kernel bridge firewall in container
Calling enable_kernel_bridge_firewall inside a
container, devstack will crash because it tries to
load a kernel module by calling 'sudo modprobe' on
net.bridge.

Change-Id: Id4718c065d5a8c507d49f38e19c2796a64221aa4
Closes-Bug: #1662194
2017-02-27 10:31:58 +02:00
Jenkins
f697274eee Merge "Fix file permissions for lib/neutron_plugins/linuxbridge_agent" 2017-02-26 06:26:01 +00:00
Jenkins
47e3e1d88e Merge "XenAPI: enable root_helper_daemon for XenServer" 2017-02-25 19:15:31 +00:00
Jens Rosenboom
f069acf9ee Make subnet pool names unique
Using the same name for two different subnet pools means that one needs
to reference them by their UUID. Choosing unique names will allow us to
use the name to reference the pool later on.

At the same time simplify the command used for pool creation by
instructing OSC to only output the value that we are interested in.

Change-Id: Idedcb6328925d44cdd0f415450ec4ebbc272401d
2017-02-24 16:37:34 +01:00
Gary Kotton
79b55f51e4 Fix file permissions for lib/neutron_plugins/linuxbridge_agent
The permissions changed with commit
40aae6adbfce1bd896d5f7b0e281e798b56d1ca8

TrivialFix

Change-Id: I100cb9589309f9289b4581265a5e4206464ddc0e
2017-02-24 13:40:19 +00:00
Jenkins
10e1e387ce Merge "Don't set external_network_bridge by default" 2017-02-24 12:00:44 +00:00
Jenkins
947af3ac61 Merge "Removed neutron_plugin_configure_debug_command functions" 2017-02-24 10:21:59 +00:00
Jenkins
5c332b09ab Merge "Corrected router gateway set command" 2017-02-24 06:32:13 +00:00
Ihar Hrachyshka
952ecb6fec Don't set external_network_bridge by default
Since the empty value is the default for the option, and when explcitly
set in config file, it triggers a deprecation warning for the option,
avoid setting it unless we actually need to override the new default
value.

Change-Id: If423114d7a52da29b97d1fb473a955d9d69a1a3e
2017-02-10 06:39:04 +00:00
Ihar Hrachyshka
47bcf4fbcb Removed neutron_plugin_configure_debug_command functions
Those are not called by devstack anymore. This cleanup also gets rid of
code that attempts to set external_network_bridge to an empty value,
which triggers a deprecation warning for the option since it's going to
be removed in a next Neutron release.

Change-Id: I5adcbab877b4e8742522de81b1a85acfc33160d7
2017-02-10 06:39:04 +00:00
Hirofumi Ichihara
40aae6adbf Down PUBLIC_BRIDGE before trying to delete it
When cleanup devstack with linuxbridge, PUBLIC_BRIDGE should be
DOWN before trying to delete it.

Change-Id: I2d205cbe4d92a03ee5c376a23282d9880dd9a1df
Closes-Bug: #1662543
2017-02-08 00:12:04 +09:00
Jenkins
0ab0e50011 Merge "Create private IPv6 subnet specifying mode flags" 2017-02-03 16:24:25 +00:00
PranaliD
705b3785ca Corrected router gateway set command
While configuring the external network as the default
router gateway for IPV6 in lib/neutron_plugins/services/l3,
"router" keyword is missing in the command.

Corrected the command.

Change-Id: I055bea5137a841f709d4865ec9a43d6b53f8f4c9
Closes-Bug: 1660712
2017-02-01 11:33:44 +05:30
Jianghua Wang
465ee45986 XenAPI: enable root_helper_daemon for XenServer
The daemon mode of root helper for XenAPI has been implemented by
this change which has been merged to neutron:
https://review.openstack.org/#/c/390931/
It will help to import the performance. Let's enable this mode
by default in devstack.

Change-Id: I52246bef3e4434dfc49446535b122580bc475ac3
2017-01-23 07:46:56 +00:00
Jenkins
775c8f4924 Merge "Reconfig ml2 ovs configuration for neutron on XenServer" 2017-01-13 18:39:10 +00:00
Brian Haley
1ec93a8fc2 Create private IPv6 subnet specifying mode flags
$ipv6_modes should always be passed when creating the
default IPv6 subnet, not just when fixed_range_v6 is
set.  Without it the default was DHCPv6, which cirros
doesn't support out of the box.  Was broken in
change-over from neutron to openstack cli.

Change-Id: Iadd39b1ce02fe0b3781bd3ae04adfd20d7e12d9f
Closes-bug: #1656098
2017-01-12 16:11:11 -05:00
Jenkins
858a105c81 Merge "Remove duplicate entry for flat_networks" 2017-01-08 17:38:26 +00:00
Jenkins
9c7bbca414 Merge "lib/neutron-legacy - Use stevedore alias for ML2 plugin" 2017-01-05 16:27:17 +00:00
yatin
0f97841dfa Remove duplicate entry for flat_networks
Currently if PHYSICAL_NETWORK and PUBLIC_PHYSICAL_NETWORK are
same then duplicate entry is created in ml2_conf.ini like below:
flat_networks = public,public,

With this patch, if PHYSICAL_NETWORK and PUBLIC_PHYSICAL_NETWORK
are same then add only PHYSICAL_NETWORK to flat_networks in
ml2_conf.ini

Change-Id: Iae4d1ee3882f6d96b4e4abd52ecc673a620563b5
Closes-Bug: #1654148
2017-01-05 12:40:11 +05:30
Jenkins
721eb4fcdd Merge "Fix provider networking error message" 2017-01-03 20:06:37 +00:00
Armando Migliaccio
36f81ff6d5 Switch to using openstack client for setting the router's gateway
Depends-on: Ifb5a4d1965cd7e75c0c8cf2cfb677e0628b699dc
Change-Id: Iba58f5275cacc7bc82fa2f2d2b96315c2350ab70
2016-12-23 11:30:24 +00:00
Dirk Mueller
30b58bfa27 Update openvswitch restart for suse
Starting with SLE12 SP2 and with openSUSE Leap the distro-shipped
openvswitch is the normal systemd openvswitch.service service file
and no longer the older openvswitch-switch Sysv5 init script. Add
a special case for that.

Change-Id: I5152f2585c3d4d18853988d6290039d6b1713b99
2016-12-09 01:00:42 +01:00
Jenkins
172b043d68 Merge "Fix devstack with linuxbridge without l3 agent" 2016-12-05 18:58:25 +00:00
Armando Migliaccio
1c08b191fd Fix devstack with linuxbridge without l3 agent
The linuxbridge agent for Neutron expects that the public bridge will
already be created by the time it starts. On devstack, this only occurs
as part of the l3 agent configuration. If a compute node doesn't have an
l3 agent and is using a linuxbridge agent, then br-ex won't be created
and the process will not be able to start (causing stack.sh to fail).

This causes the gate-grenade-dsvm-neutron-linuxbridge-multinode-nv gate
to fail. To avoid the issue, skip the bridge mappings setup unless L3 is
configured. This is done in a backward compatible fashion: if localrc
uses the old q-l3 tags, the is_service_enabled neutron-l3 would not be
able to succeed.

Closes-Bug: #1643562

Change-Id: I292ff0dc080fb84b5f879ba2f00f03eff295b55b
2016-12-02 02:21:42 +00:00