openstack
/
diskimage-builder
Code Issues Proposed changes

Stop using bash arrays for whitelisting in yum 

Using -n for bash arrays was a little bit bad, and also resulted in
errors when running under set -u. Wean the yum element off the array
and switch to a straight string.

Change-Id: Ifd61fce7dadd5820022e9b2ab42020ba0cb71ce6
This commit is contained in:
Steve Kowalik 2014-05-22 19:05:28 +10:00
parent 273d364fc4
commit e02dbd717b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
elements/yum/bin/install-packages
View File

@ -34,16 +34,16 @@ fi
# Packages that aren't available in the distro but requested for installation
# can be ignored by adding them to the exclude list
BLACKLIST=$(cat /tmp/yum-blacklist 2>/dev/null || echo "")
WHITELIST=()
WHITELIST=
for i in "$@"
do
if [[ ! ${BLACKLIST[*]} =~ $i ]]; then
WHITELIST+="$i "
WHITELIST="$WHITELIST $i"
else
echo "The package $i is not available and will not be installed"
fi
done
if [ ${#WHITELIST[@]} -eq 0 ]; then
if [ -n "$WHITELIST" ]; then
if [ -f /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release ]; then
rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release
fi