openstack/freezer-api
Code Issues Proposed changes

Using assertIsNone() instead of assertEqual(None, ...)

Browse Source 
Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(None, ...)

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: I165921ca1053041104c915bf0d3f567e6f5c09eb
This commit is contained in:
Cao Xuan Hoang
2016-09-28 08:45:11 +07:00
committed by Shangzhong Zhu
parent 0ac8349066
commit a15f8a16b1
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
freezer_api/tests/unit/test_elastic.py
View File

@@ -610,7 +610,7 @@ class TestElasticSearchEngine_job(unittest.TestCase):
self.eng.job_manager.get.return_value = None
res = self.eng.get_job(user_id=fake_client_entry_0['user_id'],
job_id=fake_client_info_0['client_id'])
self.assertEqual(res, None)
self.assertIsNone(res)
self.eng.job_manager.get.assert_called_with(
fake_client_entry_0['user_id'],
fake_client_info_0['client_id'])
@@ -745,7 +745,7 @@ class TestElasticSearchEngine_action(unittest.TestCase):
self.eng.action_manager.get.return_value = None
res = self.eng.get_action(user_id=fake_action_0['user_id'],
action_id=fake_action_0['action_id'])
self.assertEqual(res, None)
self.assertIsNone(res)
self.eng.action_manager.get.assert_called_with(
fake_action_0['user_id'],
fake_action_0['action_id'])
@@ -879,7 +879,7 @@ class TestElasticSearchEngine_session(unittest.TestCase):
self.eng.session_manager.get.return_value = None
res = self.eng.get_session(user_id=fake_session_0['user_id'],
session_id=fake_session_0['session_id'])
self.assertEqual(res, None)
self.assertIsNone(res)
self.eng.session_manager.get.assert_called_with(
fake_session_0['user_id'],
fake_session_0['session_id'])