openstack/freezer-web-ui
Code Issues Proposed changes

use . instead of source.

Browse Source 
Code conventions: Use “.” to source script files
When you have to source a script file, for example ,
a credentials file to gain access to user-only or
 admin-only CLI commands, use . instead of source.
See more:
http://docs.openstack.org/contributor-guide/writing-style/code-conventions

Change-Id: If2ef1f3f56008f7e9e1bec13b94d542a3b9667e7
This commit is contained in:
chao liu
2018-01-29 05:21:57 -08:00
parent 6746550139
commit e9e2a3769c
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
devstack/plugin.sh
View File

@@ -16,7 +16,7 @@
if is_service_enabled freezer-web-ui; then if is_service_enabled freezer-web-ui; then
if [[ "$1" == "source" || "`type -t install_freezer_web_ui`" != 'function' ]]; then if [[ "$1" == "source" || "`type -t install_freezer_web_ui`" != 'function' ]]; then
# Initial source # Initial source
source $FREEZER_WEB_UI_DIR/devstack/lib/freezer-web-ui . $FREEZER_WEB_UI_DIR/devstack/lib/freezer-web-ui
fi fi
if [[ "$1" == "stack" && "$2" == "install" ]]; then if [[ "$1" == "stack" && "$2" == "install" ]]; then

2
tools/with_venv.sh
View File

@@ -4,4 +4,4 @@ VENV_PATH=${VENV_PATH:-${TOOLS_PATH}}
VENV_DIR=${VENV_NAME:-/../.venv} VENV_DIR=${VENV_NAME:-/../.venv}
TOOLS=${TOOLS_PATH} TOOLS=${TOOLS_PATH}
VENV=${VENV:-${VENV_PATH}/${VENV_DIR}} VENV=${VENV:-${VENV_PATH}/${VENV_DIR}}
source ${VENV}/bin/activate && "$@" . ${VENV}/bin/activate && "$@"