openstack
/
glance-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9303\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9303\u003e replied on the change"}
This commit is contained in:
Gerrit User 9303 2024-05-10 15:31:20 +00:00 committed by Gerrit Code Review
parent c1f3fdf449
commit 11eeb5dbfd
1 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
52923f9fdde9e2e63e3bf667f30900ca8f7281f5
View File

@ -176,6 +176,24 @@
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3de07db8_4780f954",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 3
},
"lineNbr": 68,
"author": {
"id": 9303
},
"writtenOn": "2024-05-10T15:31:20Z",
"side": 1,
"message": "NO, this is the current behavior",
"parentUuid": "f35fb2d1_7bd1837b",
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -229,6 +247,24 @@
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "008ede29_9b547e9b",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 3
},
"lineNbr": 77,
"author": {
"id": 9303
},
"writtenOn": "2024-05-10T15:31:20Z",
"side": 1,
"message": "marker file sounds good and we can override existing disable_by_file healthcheck plugin for the same.",
"parentUuid": "59c2f8f9_2f32b447",
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -323,6 +359,30 @@
},
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8982ff86_f164ed2a",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 3
},
"lineNbr": 102,
"author": {
"id": 9303
},
"writtenOn": "2024-05-10T15:31:20Z",
"side": 1,
"message": "Agree for not returning 4xx, I wanted to say need to verify configuring healthcheck middleware disable_by_file and how it behaves on startup and for api call after service started.\n\nSurprisingly I configured the same but it doesn\u0027t made any difference (not reported any issue)\n\n\nlocal api-paste.ini changes\n\n[app:healthcheck]\npaste.app_factory \u003d oslo_middleware:Healthcheck.app_factory\nbackends \u003d disabled_by_file\ndisable_by_file_path \u003d /opt/stack/data/glance/images\n\n[filter:healthcheck]\npaste.filter_factory \u003d oslo_middleware:Healthcheck.factory\npath \u003d /healthcheck\nbackends \u003d disabled_by_file\ndisable_by_file_path \u003d /opt/stack/data/glance/images\n#### set to True to enable detailed output, False is the default\ndetailed \u003d False\n\n\n[composite:api]\nkeystone+cachemanagement \u003d cors http_proxy_to_wsgi versionnegotiation osprofiler authtoken context healthcheck cache cachemanage rootapp",
"parentUuid": "546b033a_1e8d2af8",
"range": {
"startLine": 102,
"startChar": 38,
"endLine": 102,
"endChar": 46
},
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}