openstack
/
glance-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
This commit is contained in:
Gerrit User 4393 2024-05-10 16:50:55 +00:00 committed by Gerrit Code Review
parent 11eeb5dbfd
commit c5b02a1285
1 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
52923f9fdde9e2e63e3bf667f30900ca8f7281f5
View File

@ -194,6 +194,24 @@
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d9702bc9_e5aa943f",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 3
},
"lineNbr": 68,
"author": {
"id": 4393
},
"writtenOn": "2024-05-10T16:50:55Z",
"side": 1,
"message": "How does the healthcheck currently know/report unhealthy if the mount goes away?\n\nIf that\u0027s actually currently working, then I guess I\u0027m not sure what the problem is - that seems like the ideal situation to me:\n\n - Mount available \u003d\u003d healthy\n - Mount not available \u003d\u003d unhealthy",
"parentUuid": "3de07db8_4780f954",
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -265,6 +283,24 @@
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3079603f_3b56d8e6",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 3
},
"lineNbr": 77,
"author": {
"id": 4393
},
"writtenOn": "2024-05-10T16:50:55Z",
"side": 1,
"message": "I think you want the opposite of the disable-by-file, but that should be pretty trivial. You want \"healthy if file is present\" not \"unhealthy if file present\" which is what the current plugin does, AFAICT:\n\nhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/disable_by_file.py#L115",
"parentUuid": "008ede29_9b547e9b",
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -383,6 +419,30 @@
},
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0d4a8883_856c9de0",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 3
},
"lineNbr": 102,
"author": {
"id": 4393
},
"writtenOn": "2024-05-10T16:50:55Z",
"side": 1,
"message": "It depends on if the mount is at the `glance` level or the `images` level. If the latter, then `images` will always exist, even if nothing is mounted there. If at the `glance` level, then checking for the presence of `images` may be good enough. However, you don\u0027t ever want glance to create the images/ directory if missing, otherwise an empty mount will create the dir when it shouldn\u0027t and then think it\u0027s healthy.",
"parentUuid": "8982ff86_f164ed2a",
"range": {
"startLine": 102,
"startChar": 38,
"endLine": 102,
"endChar": 46
},
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}