Correct text in error response
The text message earlier was not helpful while listing members of a public image. A more helpful message will be given to user after this commit is accepted. Change-Id: Ifa2df37baea50c78c622344847f2c7117c17e3f4 Closes-bug: 1434501
This commit is contained in:
parent
6dc5477a12
commit
73eff83763
|
@ -160,10 +160,10 @@ class ImageMembersController(object):
|
||||||
msg = _("Image %s not found.") % image_id
|
msg = _("Image %s not found.") % image_id
|
||||||
LOG.warning(msg)
|
LOG.warning(msg)
|
||||||
raise webob.exc.HTTPNotFound(explanation=msg)
|
raise webob.exc.HTTPNotFound(explanation=msg)
|
||||||
except exception.Forbidden:
|
except exception.Forbidden as e:
|
||||||
msg = _("Not allowed to list members for image %s.") % image_id
|
msg = _("Not allowed to list members for image %s.") % image_id
|
||||||
LOG.warning(msg)
|
LOG.warning(e.msg or msg)
|
||||||
raise webob.exc.HTTPForbidden(explanation=msg)
|
raise webob.exc.HTTPForbidden(explanation=e.msg or msg)
|
||||||
|
|
||||||
def show(self, req, image_id, member_id):
|
def show(self, req, image_id, member_id):
|
||||||
"""
|
"""
|
||||||
|
|
|
@ -3118,6 +3118,7 @@ class TestImageMembers(functional.FunctionalTest):
|
||||||
# Image members forbidden for public image
|
# Image members forbidden for public image
|
||||||
path = self._url('/v2/images/%s/members' % image_fixture[0]['id'])
|
path = self._url('/v2/images/%s/members' % image_fixture[0]['id'])
|
||||||
response = requests.get(path, headers=get_header('tenant1'))
|
response = requests.get(path, headers=get_header('tenant1'))
|
||||||
|
self.assertIn("Public images do not have members", response.text)
|
||||||
self.assertEqual(403, response.status_code)
|
self.assertEqual(403, response.status_code)
|
||||||
|
|
||||||
# Image Member Cannot delete Image membership
|
# Image Member Cannot delete Image membership
|
||||||
|
|
Loading…
Reference in New Issue