glance/HACKING.rst
Sachin Patil 50b0252a25 Corrected section underline
Section underline must be at least as long as the title text

Change-Id: I13f5398bb564c91af6c721c699a5552f2a07e561
2016-04-15 11:40:59 +05:30

1.3 KiB

glance Style Commandments

glance Specific Commandments

  • [G316] Change assertTrue(isinstance(A, B)) by optimal assert like assertIsInstance(A, B)
  • [G317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B)
  • [G318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like assertIsNone(A)
  • [G319] Validate that debug level logs are not translated
  • [G320] For python 3 compatibility, use six.text_type() instead of unicode()
  • [G321] Validate that LOG messages, except debug ones, have translations
  • [G322] Validate that LOG.info messages use _LI.
  • [G323] Validate that LOG.exception messages use _LE.
  • [G324] Validate that LOG.error messages use _LE.
  • [G325] Validate that LOG.critical messages use _LC.
  • [G326] Validate that LOG.warning messages use _LW.
  • [G327] Prevent use of deprecated contextlib.nested
  • [G328] Must use a dict comprehension instead of a dict constructor with a sequence of key-value pairs
  • [G329] Python 3: Do not use xrange.
  • [G330] Python 3: do not use dict.iteritems.
  • [G331] Python 3: do not use dict.iterkeys.
  • [G332] Python 3: do not use dict.itervalues.