openstack/glance
Code Issues Proposed changes
623492cc21
glance/HACKING.rst
Erno Kuvaja 87a56ce5c7 Stop enforcing translations on logs 
Translations team has stopped translating the logs. We need to
stop enforcing the usage of translation functions on logging.

Change-Id: I56900846ce8ea92eaa3873f64b383a36a4974908
2017-05-31 11:35:53 +01:00

979 B
Raw Blame History

glance Style Commandments

glance Specific Commandments

  • [G316] Change assertTrue(isinstance(A, B)) by optimal assert like assertIsInstance(A, B)
  • [G317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B)
  • [G318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like assertIsNone(A)
  • [G319] Validate that debug level logs are not translated
  • [G320] For python 3 compatibility, use six.text_type() instead of unicode()
  • [G327] Prevent use of deprecated contextlib.nested
  • [G328] Must use a dict comprehension instead of a dict constructor with a sequence of key-value pairs
  • [G329] Python 3: Do not use xrange.
  • [G330] Python 3: do not use dict.iteritems.
  • [G331] Python 3: do not use dict.iterkeys.
  • [G332] Python 3: do not use dict.itervalues.